Skip to content

Always update (allow for controlled components) #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bvandenbos wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Always update (allow for controlled components) #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d8f39f
always update - allow for controlled components
May 3, 2017
7269d84
Remove corresponding test
bvandenbos May 3, 2017
9927102
Revert "Remove corresponding test"
bvandenbos May 3, 2017
c6dc78e
Remove corresponding test
bvandenbos May 3, 2017
46a9b4c
Revert "Remove corresponding test"
bvandenbos May 3, 2017
445b3dd
updating test
bvandenbos May 3, 2017
f0579d5
updating test
bvandenbos May 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/Slider.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,11 +577,6 @@ class Rheostat extends React.Component {

// istanbul ignore next
updateNewValues(nextProps) {
// Don't update while the slider is sliding
if (this.state.slidingIndex !== null) {
return;
}

const { max, min, values } = nextProps;

const nextValues = this.validateValues(values, nextProps);
Expand Down
4 changes: 2 additions & 2 deletions test/slider-test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,15 +112,15 @@ describe('<Slider />', () => {
assert(onChange.callCount === 0, 'onChange was not called');
});

it('should not update values if we are sliding', () => {
it('should update values when we are sliding', () => {
const onChange = sinon.spy();
const slider = mount(<Slider onChange={onChange} values={[0]} />);

slider.setState({ slidingIndex: 0 });

slider.setProps({ values: [50] });

assert(onChange.callCount === 0, 'updateNewValues was not called');
assert(onChange.callCount === 1, 'updateNewValues was called');
});

it('should not update values if they are the same', () => {
Expand Down