Support for configuring audio codec and video framerate#177

Merged

ammen99 merged 26 commits intoammen99:masterfrom

llyyr:happysmash-master

Jul 8, 2022

Commits on Jul 7, 2022

Add rough support for changing audio codecs

happysmash27
authored and
llyyr
committed
Updated README.md

happysmash27
authored and
llyyr
committed
Changed audio codec option to -C

happysmash27
authored and
llyyr
committed
Added rough implementation of audio codec, sample format, sample rate, and frame rate

happysmash27
authored and
llyyr
committed
Rewrote help documentation to reflect new options

happysmash27
authored and
llyyr
committed
Added fallback onto auto fmt, miscillanious fixes, broke something to be debugged soon

happysmash27
authored and
llyyr
committed
Fixed thing that gave confusing syntax error?

happysmash27
authored and
llyyr
committed
Fixed error output when user puts in invalid format; removed colon from format messages

happysmash27
authored and
llyyr
committed
Fixed typo in perenthesis; fixed some wildly inconsistent whitespace

happysmash27
authored and
llyyr
committed
Removed some commented out code

happysmash27
authored and
llyyr
committed
When given an invalid format, wf-recorder errors out instead of choosing alternative. Also made log output more descriptive when this happens

happysmash27
authored and
llyyr
committed
Finally got meson configuration options to work correctly

happysmash27
authored and
llyyr
committed
Made man page congruent with --help

happysmash27
authored and
llyyr
committed
Removed my references to default values, because the default values can be configured

happysmash27
authored and
llyyr
committed
Made default sample format use configured default sample format

happysmash27
authored and
llyyr
committed
Renamed DEFAULT_SAMPLE_FMT to FALLBACK_SAMPLE_FMT to reflect true purpose

happysmash27
authored and
llyyr
committed
Also give chosen sample format when it is automatically chosen

happysmash27
authored and
llyyr
committed
Copied the method get_codec_auto_sample_fmt appears to use to still work if it is not defined which sample formats a codec supports

happysmash27
authored and
llyyr
committed
Made logging of the sample format used when user specified more similar to the logging of the sample format automatically chosen

happysmash27
authored and
llyyr
committed
"video pixel format" -> "output video pixel format" in documentation

happysmash27
authored and
llyyr
committed
Code style and rebase fixes
llyyr
committed
Make audio options clearer to understand (acodec -> audio_codec)
llyyr
committed
Add missing --sample-format (-X) from help function
llyyr
committed
Change default sample rate to 48000
llyyr
committed
Update manpage
llyyr
committed
Move duplicate code to function
llyyr
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support for configuring audio codec and video framerate#177

Support for configuring audio codec and video framerate#177
ammen99 merged 26 commits intoammen99:masterfrom
llyyr:happysmash-master

Commits on Jul 7, 2022

Add rough support for changing audio codecs

Updated README.md

Changed audio codec option to -C

Added rough implementation of audio codec, sample format, sample rate, and frame rate

Rewrote help documentation to reflect new options

Added fallback onto auto fmt, miscillanious fixes, broke something to be debugged soon

Fixed thing that gave confusing syntax error?

Fixed error output when user puts in invalid format; removed colon from format messages

Fixed typo in perenthesis; fixed some wildly inconsistent whitespace

Removed some commented out code

When given an invalid format, wf-recorder errors out instead of choosing alternative. Also made log output more descriptive when this happens

Finally got meson configuration options to work correctly

Made man page congruent with --help

Removed my references to default values, because the default values can be configured

Made default sample format use configured default sample format

Renamed DEFAULT_SAMPLE_FMT to FALLBACK_SAMPLE_FMT to reflect true purpose

Also give chosen sample format when it is automatically chosen

Copied the method get_codec_auto_sample_fmt appears to use to still work if it is not defined which sample formats a codec supports

Made logging of the sample format used when user specified more similar to the logging of the sample format automatically chosen

"video pixel format" -> "output video pixel format" in documentation

Code style and rebase fixes

Make audio options clearer to understand (acodec -> audio_codec)

Add missing --sample-format (-X) from help function

Change default sample rate to 48000

Update manpage

Move duplicate code to function