Skip to content

Conversation

@llyyr
Copy link
Contributor

@llyyr llyyr commented Jul 7, 2022

Rebase #102

happysmash27 and others added 21 commits July 7, 2022 17:23
…ing alternative. Also made log output more descriptive when this happens
…ork if it is not defined which sample formats a codec supports
…ar to the logging of the sample format automatically chosen
Copy link
Owner

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things which I noticed after reading the PR again.

@llyyr llyyr force-pushed the happysmash-master branch from 13126ec to 5696ee9 Compare July 7, 2022 17:34
Copy link
Owner

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @llyyr for finishing up the work and thanks to @happysmash27 for the original work!

@llyyr
Copy link
Contributor Author

llyyr commented Jul 8, 2022

Are there any plans to make a new release? I think it'd be a good idea

@ammen99
Copy link
Owner

ammen99 commented Jul 8, 2022

Are there any plans to make a new release? I think it'd be a good idea

Yeah, but let's first give people some time to test this.

@apiraino
Copy link

Thanks for everyone working on this! Please let me know if I should file a separate issue.

Which are the possible values for -c, --codec and the new -C, --audio-codec? I've tried using --audio-codec=mp3 or --audio-codec=ogg but they both don't work. Maybe a couple of examples in the wiki to get people started?

If this depends on the local installation of ffmpeg, how can I discover what is supported on my machine (ffmpeg -codecs show all supported codecs from ffmpeg)?

@apiraino
Copy link

apiraino commented Jul 12, 2022

Ok, answering my own question.

To check all available audio encoders: ffmpeg -encoders 2>&1 | grep "^ A"

To check all available video encoders: ffmpeg -encoders 2>&1 | grep "^ V"

So for example one can now use: wf-recorder -a --codec libx264 --audio-codec=libvorbis

ref: #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants