-
Notifications
You must be signed in to change notification settings - Fork 78
Support for configuring audio codec and video framerate #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… be debugged soon
…om format messages
…ing alternative. Also made log output more descriptive when this happens
…ork if it is not defined which sample formats a codec supports
…ar to the logging of the sample format automatically chosen
ammen99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things which I noticed after reading the PR again.
ammen99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks @llyyr for finishing up the work and thanks to @happysmash27 for the original work!
|
Are there any plans to make a new release? I think it'd be a good idea |
Yeah, but let's first give people some time to test this. |
|
Thanks for everyone working on this! Please let me know if I should file a separate issue. Which are the possible values for If this depends on the local installation of ffmpeg, how can I discover what is supported on my machine ( |
|
Ok, answering my own question. To check all available audio encoders: To check all available video encoders: So for example one can now use: ref: #34 |
Rebase #102