Skip to content

docs: fix help and examples regarding -a & --audio #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ammen99 merged 1 commit into from
Jul 30, 2022
Merged

docs: fix help and examples regarding -a & --audio #180

ammen99 merged 1 commit into from
Jul 30, 2022

Conversation

@llyyr
Copy link
Contributor

@llyyr llyyr commented Jul 26, 2022

No description provided.

@llyyr llyyr force-pushed the audio-device-opt branch from e04a340 to 08d363e Compare July 26, 2022 11:40
@llyyr llyyr force-pushed the audio-device-opt branch from 08d363e to cc5baa2 Compare July 26, 2022 11:48
@llyyr
Copy link
Contributor Author

llyyr commented Jul 26, 2022

Readme file from wf-recorder-x fork has useful information that should be linked or integrated in this project's readme in some way as well.

@apiraino
Copy link

apiraino commented Jul 26, 2022

@llyyr thanks for encoding these useful info in the README.

Anything useful to salvage from my comment? Maybe some usage examples? I recall I was a bit confused on which part of the ffmpeg command output provided the exact string to be used with wf-recorder (maybe it was me being a bit thick)

@llyyr
Copy link
Contributor Author

llyyr commented Jul 26, 2022

Better version of your comment is already in the readme after this PR. I don't mind doing more examples but it should be fairly obvious what wf-recorder can do. And if I start writing examples for ffmpeg functionality there won't be an end.

@apiraino
Copy link

apiraino commented Jul 26, 2022

on a second thought: examples can also fit somewhere in the wiki.

ammen99
ammen99 approved these changes Jul 30, 2022
View reviewed changes
Copy link
Owner

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to have grown quite a long list of options. LGTM and thanks!

@ammen99 ammen99 merged commit 761eb52 into ammen99:master Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ammen99 ammen99 ammen99 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@llyyr @apiraino @ammen99