Skip git-based version if building from tarballs #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I am not sure, isn't it enough to just set |
Contributor
Author
|
Setting |
Owner
|
I'd prefer to set |
WhyNotHugo
added a commit
to WhyNotHugo/wf-recorder
that referenced
this pull request
Aug 23, 2023
This allows downstream distributions to builds from tarballs which lack any git metadata. See: ammen99#226
WhyNotHugo
force-pushed
the
build-from-tarballs
branch
from
78e5dc4 to
6d0afc0
Compare
Contributor
Author
|
Tested via: mv .git _git
meson build
meson compile -C build
mv _git .git
git clean -xdf
meson build
meson compile -C build |
Owner
|
Please write out |
WhyNotHugo
force-pushed
the
build-from-tarballs
branch
from
6d0afc0 to
8f9f058
Compare
Contributor
Author
|
Done |
This allows downstream distributions to builds from tarballs which lack any git metadata. See: ammen99#226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows downstream distributions to builds from tarballs which lack any git metadata.