Added option to skip checks on UniqueSortIndex #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because I'm usually dealing with a known-sorted array, and want an easy interface to constructing an
AcceleratedArray
without any of the sorting & checks.In terms of the interface: having a bool argument seemed quick and easy. Could instead add a new type
PreSorted
or something and dispatch on that as an argument, which would give type inference without relying on constant propagation.I also thought about doing this for SortIndex, but noticed that it has the
n_unique
field + computation which makes things tricky. That field doesn't actually seem to ever be used in the package - could we ditch it?