Skip to content

Added option to skip checks on UniqueSortIndex #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2020

Conversation

kcajf
Copy link
Contributor

@kcajf kcajf commented May 9, 2020

This is because I'm usually dealing with a known-sorted array, and want an easy interface to constructing an AcceleratedArray without any of the sorting & checks.

In terms of the interface: having a bool argument seemed quick and easy. Could instead add a new type PreSorted or something and dispatch on that as an argument, which would give type inference without relying on constant propagation.

I also thought about doing this for SortIndex, but noticed that it has the n_unique field + computation which makes things tricky. That field doesn't actually seem to ever be used in the package - could we ditch it?

Copy link
Owner

@andyferris andyferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm torn between keyword and positional argument here. I can't imagaine what else we could do with a 3-arg form and it's possible to deprecate this, so this'll do :)

@andyferris andyferris merged commit d45fffb into andyferris:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants