Added getindex and view for UniqueSortIndex with a UnitRange #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyferris
requested changes
May 21, 2020
|
In the future, the nice one will be indexing a sorted array with a sorted array :) |
andyferris
approved these changes
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements indexing of a straightforwardly ordered UniqueSortIndex with a UnitRange. This is the case that comes up almost 100% of the time for me (usually taking a positive-step slice of an array indexed with some unique, increasing Dates).
I also looked at implementing for SortIndex, but was thrown off by the
n_uniqueso left it for now.The construction of the return AAs would also be made simpler if #10 merges.
I added some notes at the bottom for further TODOs. StepRanges are annoying because they retain sortedness depending on the sign of their step.