fix: resolve auto-fix failures and detection for short module names (… #4897
+45
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an inconsistency in the
no-free-formrule where the auto-fix (transformer) failed to recognize tasks using short module names (e.g.,file:instead ofansible.builtin.file:).Changes:
MatchError.detailsproperty, ensuring the transformer knows exactly which key to target.transformlogic to handle both FQCN and short-name keys, preventingTypeErrorcrashes and partial string remains.rule-no-free-form-fail.ymlcovering short names with multiple parameters, names without task descriptions, and collection-based modules.Fixes #4750