Fix HTTPClient crash when download fails before shutdown #837
+12
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Currently, when
FileDownloader.downloadFile()encounters an error duringclient.execute()(e.g., XPC connection interruption or network timeout), theHTTPClientinstance is deallocated without callingshutdown(), resulting in a crash:AsyncHTTPClient/HTTPClient.swift:187: Fatal error: Client not shut down before the deinit.This caused a control flow issue when attempting to download the default kernel during
container system startand, under certain conditions (e.g., network latency), encountering the timeout errorHTTPClientError.connectTimeout.To address this,
client.execute()is now wrapped in a do/catch to ensureshutdown()is always called on both success and error paths. Also I've added an explicit timeout configuration (30s connect, no read timeout) to better accommodate large file downloads.Testing