Skip to content

Fix HTTPClient crash when download fails before shutdown #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcantah merged 1 commit into from
Nov 3, 2025
Merged

Fix HTTPClient crash when download fails before shutdown #837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Sources/ContainerClient/FileDownloader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,23 @@ public struct FileDownloader {
})

let client = FileDownloader.createClient(url: url)
_ = try await client.execute(request: request, delegate: delegate).get()
do {
_ = try await client.execute(request: request, delegate: delegate).get()
} catch {
try? await client.shutdown()
throw error
}
try await client.shutdown()
}

private static func createClient(url: URL) -> HTTPClient {
var httpConfiguration = HTTPClient.Configuration()
// for large file downloads we keep a generous connect timeout, and
// no read timeout since download durations can vary
httpConfiguration.timeout = HTTPClient.Configuration.Timeout(
connect: .seconds(30),
read: .none
)
if let host = url.host {
let proxyURL = ProxyUtils.proxyFromEnvironment(scheme: url.scheme, host: host)
if let proxyURL, let proxyHost = proxyURL.host {
Expand Down