avoid tmpnet to create empty genesis on disk #3868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maru-ava
reviewed
Apr 8, 2025
maru-ava
reviewed
Apr 8, 2025
yacovm
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Certain tmpnet configurations have a nil genesis field, such as fuji/mainnet/local network.
On write, an empty genesis file is always created in such cases, and, when reading the network again,
this genesis field is not nil anymore.
As some parts of the network initialization code check for genesis field being or not nil, it is
safer to just keep the disk storage aligned with the original conf.
How this works
How this was tested
Need to be documented in RELEASES.md?