Skip to content

avoid tmpnet to create empty genesis on disk #3868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

avoid tmpnet to create empty genesis on disk #3868

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59a0dba
avoid tmpnet to create empty genesis on disk
felipemadero Apr 8, 2025
98e6347
address MN comments
felipemadero Apr 8, 2025
1988b77
address MN comment
felipemadero Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions tests/fixture/tmpnet/network_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"github.com/ava-labs/avalanchego/genesis"
"github.com/ava-labs/avalanchego/utils/crypto/secp256k1"
"github.com/ava-labs/avalanchego/utils/perms"
"github.com/ava-labs/avalanchego/utils/storage"
)

// The Network type is defined in this file (reading/writing configuration) and network.go
Expand Down Expand Up @@ -87,25 +88,31 @@ func (n *Network) GetGenesisPath() string {
}

func (n *Network) readGenesis() error {
bytes, err := os.ReadFile(n.GetGenesisPath())
if err != nil {
return fmt.Errorf("failed to read genesis: %w", err)
}
genesis := genesis.UnparsedConfig{}
if err := json.Unmarshal(bytes, &genesis); err != nil {
return fmt.Errorf("failed to unmarshal genesis: %w", err)
if exists, err := storage.FileExists(n.GetGenesisPath()); err != nil {
return err
} else if exists {
bytes, err := os.ReadFile(n.GetGenesisPath())
if err != nil {
return fmt.Errorf("failed to read genesis: %w", err)
}
genesis := genesis.UnparsedConfig{}
if err := json.Unmarshal(bytes, &genesis); err != nil {
return fmt.Errorf("failed to unmarshal genesis: %w", err)
}
n.Genesis = &genesis
}
n.Genesis = &genesis
return nil
}

func (n *Network) writeGenesis() error {
bytes, err := DefaultJSONMarshal(n.Genesis)
if err != nil {
return fmt.Errorf("failed to marshal genesis: %w", err)
}
if err := os.WriteFile(n.GetGenesisPath(), bytes, perms.ReadWrite); err != nil {
return fmt.Errorf("failed to write genesis: %w", err)
if n.Genesis != nil {
bytes, err := DefaultJSONMarshal(n.Genesis)
if err != nil {
return fmt.Errorf("failed to marshal genesis: %w", err)
}
if err := os.WriteFile(n.GetGenesisPath(), bytes, perms.ReadWrite); err != nil {
return fmt.Errorf("failed to write genesis: %w", err)
}
}
return nil
}
Expand Down