Remove tx from pool when its score is lower than a configured value#7576
Merged
fab-10 merged 6 commits intobesu-eth:mainfrom Sep 5, 2024
Merged
Remove tx from pool when its score is lower than a configured value#7576fab-10 merged 6 commits intobesu-eth:mainfrom
fab-10 merged 6 commits intobesu-eth:mainfrom
Conversation
fab-10
force-pushed
the
remove-tx-below-configurable-score
branch
from
6d188eb to
f7108ff
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
remove-tx-below-configurable-score
branch
from
f7108ff to
82f81f0
Compare
pinges
approved these changes
Sep 5, 2024
Contributor
pinges
left a comment
pinges
left a comment
There was a problem hiding this comment.
One proposal, otherwise LGTM
besu/src/main/java/org/hyperledger/besu/cli/options/TransactionPoolOptions.java
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/layered/AbstractTransactionsLayer.java # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/layered/LayeredPendingTransactions.java # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/layered/TransactionsLayer.java
…nPoolOptions.java Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
added
the
doc-change-required
…0/besu into remove-tx-below-configurable-score
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
8 tasks
m4sterbunny
removed
the
doc-change-required
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Introduce a new option
--tx-pool-min-score, that takes values between-128and127, that instruct the txpool to remove pending txs when their score is below the option value.By default the value is
-128, that is also the lowest score a pending tx can have, and basically means that the pending tx will not be removed and will stay in the pool with the lowest score, so it will be selected after all the other pending txsFixed Issue(s)
fixes #7572
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests