Support pending transaction score when saving and restoring txpool#8363
Merged
fab-10 merged 1 commit intobesu-eth:mainfrom Mar 4, 2025
Merged
Support pending transaction score when saving and restoring txpool#8363fab-10 merged 1 commit intobesu-eth:mainfrom
fab-10 merged 1 commit intobesu-eth:mainfrom
Conversation
fab-10
force-pushed
the
txpool-save-restore-score
branch
2 times, most recently
from
2e151d5 to
7f57a5f
Compare
macfarla
reviewed
Mar 3, 2025
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
do we need to doc this? where does the score come from?
| sbScore.append(line.charAt(i++)); | ||
| } | ||
| final byte score = | ||
| sbScore.isEmpty() ? MAX_SCORE : Byte.parseByte(sbScore.toString()); |
Contributor
There was a problem hiding this comment.
maybe would be clearer to extract 878-884 to a method?
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
txpool-save-restore-score
branch
from
7f57a5f to
1e0586f
Compare
Contributor
Author
Score for txpool come from this #7576, and there is no need to update doc, because not saving the score is basically a bug |
macfarla
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests