Skip to content

unstable options help - ensure no duplicates#8662

Merged
macfarla merged 4 commits intobesu-eth:mainfrom
macfarla:unstable-help-subcommand
May 22, 2025
Merged

unstable options help - ensure no duplicates#8662
macfarla merged 4 commits intobesu-eth:mainfrom
macfarla:unstable-help-subcommand

Conversation

@macfarla
Copy link
Copy Markdown
Contributor

@macfarla macfarla commented May 22, 2025

Signed-off-by: Sally MacFarlane macfarla.github@gmail.com## PR description

Fixed Issue(s)

fixes #8661
Also added a test for Unstable options subcommand

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

macfarla added 4 commits May 22, 2025 10:49
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla added the ux label May 22, 2025
Copy link
Copy Markdown
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy!

@macfarla macfarla enabled auto-merge (squash) May 22, 2025 01:22
@macfarla macfarla merged commit 0367045 into besu-eth:main May 22, 2025
48 checks passed
@macfarla macfarla deleted the unstable-help-subcommand branch May 22, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot display experimental options with -X or --Xhelp

2 participants