CLI options tests - check error first; fix typo rpl#8666
Merged
macfarla merged 2 commits intobesu-eth:mainfrom May 22, 2025
Merged
CLI options tests - check error first; fix typo rpl#8666macfarla merged 2 commits intobesu-eth:mainfrom
macfarla merged 2 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Related to #8662 - if the besu command errors, the
commandOutputis empty, and if that's checked first, you don't see what the error is. with the order reversed, if there's an error, it will be visible.Think it only affects tests that are asserting something specific about the commandOutput so I updated all those spots
eg
checking the commandOutput first you'd get
whereas if you check the error first, you get
Also fixed a typo RPL/RLP
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests