Skip to content

Adding streamerDQMOnlineScouting streamer files from Run392642 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2025

Conversation

jprendi
Copy link
Contributor

@jprendi jprendi commented Jun 27, 2025

Dear DQM-Integration community,

the addition of a new Scouting Online DQM Stream (as discussed here and here) lead to the preparation of a new HLT scouting DQM online client. The new so-called DQMOnlineScouting requires new streamer files to run the unit tests on. In this PR, I added the streamer files specifically for that stream, updated the documentation to include this new streamer files and also added a recipe on how the streamer files were produced.

Thanks in advance.

@cmsbuild
Copy link
Contributor

Pull request #11 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2025

cms-bot internal usage

@jprendi jprendi marked this pull request as ready for review June 27, 2025 07:37
README.md Outdated
@@ -26,7 +26,11 @@ Currently the unitTest that make use of input streamer files are:
run362321/run362321_ls0231_streamHIDQM_pid276864.dat
run362321/run362321_ls0231_streamHIDQM_pid276864.jsn
```

* the `scouting_dqm_sourceclient-live_cfg.py` reads the `streamDQMOnlineScouting` streamer files generated from run 392642 (from Run2025C pp run, [OMS link](https://cmsoms.cern.ch/cms/runs/report?cms_run=392642&cms_run_sequence=GLOBAL-RUN):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picky a paranthesis is missing here :)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jprendi for branch main.

@akritkbehera, @antoniovagnerini, @cmsbuild, @ctarricone, @iarspider, @rseidita, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

README.md Outdated
@@ -124,6 +128,69 @@ cmsRun hlt.py &> hlt.log
rm -f run362321/run362321_ls0*_index*.*
```

The streamer files for the streamDQMOnlineScouting were prepared using the scouting specific menu:
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```bash

will render it nicer!

README.md Outdated
@@ -124,6 +128,69 @@ cmsRun hlt.py &> hlt.log
rm -f run362321/run362321_ls0*_index*.*
```

The streamer files for the streamDQMOnlineScouting were prepared using the scouting specific menu:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The streamer files for the streamDQMOnlineScouting were prepared using the scouting specific menu:
The streamer files for the `streamDQMOnlineScouting` were prepared using the scouting specific menu:

README.md Outdated
mkdir -p prepared
cat run392642/run392642_ls0000_streamDQMOnlineScouting_pid${job_pid}.ini run392642/run392642_ls0174_streamDQMOnlineScouting_pid${job_pid}.dat > prepared/run392642_ls0174_streamDQMOnlineScouting_pid${job_pid}.dat
```
In the end, one needs to `cat`the resulting `.dat` and `.ini` file into a combined `.dat` file!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this line needed? (I'ts literally what the script does in the last line)

@cmsbuild
Copy link
Contributor

Pull request #11 was updated.

@mmusich
Copy link
Contributor

mmusich commented Jun 27, 2025

test parameters:

@cmsbuild
Copy link
Contributor

Pull request #11 was updated.

@mmusich
Copy link
Contributor

mmusich commented Jun 27, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6714c2/46952/summary.html
COMMIT: 34baa6b
CMSSW: CMSSW_15_1_X_2025-06-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/DQM-Integration/11/46952/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6714c2/46952/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6714c2/46952/git-merge-result

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen: This PR was tested with cms-sw/cmssw#48398, please check if they should be merged together

@antoniovagnerini
Copy link

+dqm

@mmusich
Copy link
Contributor

mmusich commented Jul 1, 2025

@akritkbehera,@iarspider, @rseidita, @smuzaffar any objections to merge this addition?
We'll need it for cms-sw/cmssw#48398, whose backport (cms-sw/cmssw#48450) is needed for online data-taking next week.

@smuzaffar
Copy link
Contributor

+externals

new data files which looks like only used by new unit test added via https://github.com/cms-sw/cmssw/pull/48398/files#diff-b31b8d983593343c10bd8e9fbef9520af282683368c21c4c520f19c3ad83574f

@jprendi @antoniovagnerini , I think this change can go in to IB even before cms-sw/cmssw#48398 ... right?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2025

This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#48398

@mmusich
Copy link
Contributor

mmusich commented Jul 1, 2025

right?

right.

@smuzaffar smuzaffar merged commit ac77e34 into cms-data:main Jul 1, 2025
10 checks passed
@smuzaffar
Copy link
Contributor

this should be available in 11h00 IB today

@mandrenguyen
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants