-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Implement a GenericProduct
and GenericCloner
test module
#46821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cms-bot internal usage |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46821/42824
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: HeaderConsistency Comparison SummarySummary:
|
339cf8b
to
e486093
Compare
Rebased to include the fix from #46825 so the tests should now pass. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46821/42832
|
Pull request #46821 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again. |
@Dr15Jones @makortel this is very preliminary, but id does seem to work. Some random questions:
|
please test |
This EDProducer will clone all the event products declared by its configuration, using their ROOT dictionaries.
3b462b2
to
8ed3144
Compare
Pull request #46821 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again. |
please test 🤷🏻♂️ |
+1 Size: This PR adds an extra 40KB to repository Comparison SummarySummary:
|
8ed3144
to
5bd0828
Compare
+1 Size: This PR adds an extra 36KB to repository Comparison SummarySummary:
|
PR description:
Implement additional framework functionality used by the MPI-based modules developed in #32632:
edm::GenericProduct
can be used to produce any collection using its ROOT dictionary;edmtest::GenericCloner
can be used to clone the event products declared by its configuration, using their ROOT dictionaries.Extend few core features:
edm::Wrapper<T>
can be populated moving from an object using a type-erasedvoid*
and the object'sstd::type_info
;edm::WrapperBase
provides themoveFrom()
public interface.PR validation:
New unit test pass.