Implement additional framework integration tests #47425

fwyzard · 2025-02-21T19:28:06Z

PR description:

Implement integration tests for standard types:

an edm::global::EDProducer that produces an int;
an edm::global::EDAnalyzer that consumes an int and compares it with the expected value;
an edm::global::EDProducer that produces a float;
an edm::global::EDAnalyzer that consumes a float and compares it with the expected value;
an edm::global::EDProducer that produces a std::string;
an edm::global::EDAnalyzer that consumes a std::string and compares it with the expected value;
an edm::global::EDProducer that produces a std::vector<double>;
an edm::global::EDAnalyzer that consumes a std::vector<double> and compares it with the expected values.

Implement integration tests for the post_insert() functionality.

PR validation:

The new integration tests pass.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 15.0.x as part of the MPI work.

fwyzard · 2025-02-21T19:28:29Z

please test

cmsbuild · 2025-02-21T19:28:30Z

cms-bot internal usage

cmsbuild · 2025-02-21T19:31:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47425/43819

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/TestObjects/interface/ThingWithDoNotSort.h modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File DataFormats/TestObjects/interface/ThingWithPostInsert.h modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File DataFormats/TestObjects/src/classes.h modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File DataFormats/TestObjects/src/classes_def.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/plugins/BuildFile.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/plugins/GlobalIntProducer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/plugins/GlobalStringAnalyzer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/plugins/GlobalStringProducer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/plugins/PostInsertProducer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/test/BuildFile.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/test/testPostInsertProducer_cfg.py modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/test/testStdProducts_cfg.py modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821

cmsbuild · 2025-02-21T19:31:29Z

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

DataFormats/TestObjects (core)
FWCore/Integration (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @mmusich, @rovere, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2025-02-21T21:29:04Z

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cda05c/44563/summary.html
COMMIT: c997efb
CMSSW: CMSSW_15_1_X_2025-02-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47425/44563/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 4 lines from the logs
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3920300
DQMHistoTests: Total failures: 75
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3920205
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 214 log files, 184 edm output root files, 49 DQM output files
TriggerResults: no differences found

FWCore/Integration/plugins/GlobalIntProducer.cc

FWCore/Integration/plugins/GlobalStringAnalyzer.cc

FWCore/Integration/plugins/PostInsertProducer.cc

FWCore/Integration/test/testPostInsertProducer_cfg.py

FWCore/Integration/test/testStdProducts_cfg.py

fwyzard · 2025-02-22T06:57:15Z

please test

cmsbuild · 2025-02-22T06:57:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47425/43820

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/TestObjects/interface/ThingWithDoNotSort.h modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File DataFormats/TestObjects/interface/ThingWithPostInsert.h modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File DataFormats/TestObjects/src/classes.h modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File DataFormats/TestObjects/src/classes_def.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/plugins/BuildFile.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/plugins/GlobalIntProducer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/plugins/GlobalStringAnalyzer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/plugins/GlobalStringProducer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/plugins/PostInsertProducer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/test/BuildFile.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/test/testPostInsertProducer_cfg.py modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821
- File FWCore/Integration/test/testStdProducts_cfg.py modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821

fwyzard · 2025-02-25T15:09:26Z

Could you also update FWCore/TestModules/README.md for the new modules? Given the repetitive nature, I think a single entry for all, or two entries (one for producers and one for analyzers) would be sufficient.

Done.

fwyzard · 2025-02-25T15:09:42Z

please test

cmsbuild · 2025-02-25T15:13:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47425/43865

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/TestObjects/interface/ThingWithDoNotSort.h modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File DataFormats/TestObjects/interface/ThingWithPostInsert.h modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File DataFormats/TestObjects/src/classes.h modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File DataFormats/TestObjects/src/classes_def.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/Integration/plugins/BuildFile.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/Integration/plugins/PostInsertProducer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/Integration/test/BuildFile.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/Integration/test/testPostInsertProducer_cfg.py modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/Integration/test/testStdProducts_cfg.py modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/TestModules/README.md modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/TestModules/plugins/GlobalFloatAnalyzer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/TestModules/plugins/GlobalFloatProducer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/TestModules/plugins/GlobalIntAnalyzer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/TestModules/plugins/GlobalIntProducer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/TestModules/plugins/GlobalStringAnalyzer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/TestModules/plugins/GlobalStringProducer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/TestModules/plugins/GlobalVectorAnalyzer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444
- File FWCore/TestModules/plugins/GlobalVectorProducer.cc modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Modernise the interface of ObjectWithDict #47442, Implement edm::ProductNamePattern #47444

cmsbuild · 2025-02-25T15:13:32Z

Pull request #47425 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

fwyzard · 2025-02-25T15:16:21Z

please test

cmsbuild · 2025-02-25T17:25:25Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cda05c/44648/summary.html
COMMIT: 60b81a3
CMSSW: CMSSW_15_1_X_2025-02-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47425/44648/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3920300
DQMHistoTests: Total failures: 73
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3920207
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 214 log files, 184 edm output root files, 49 DQM output files
TriggerResults: no differences found

makortel · 2025-02-25T19:25:32Z

Comparison differences are related to #47071

makortel · 2025-02-25T19:25:46Z

+core

cmsbuild · 2025-02-25T19:25:55Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

fwyzard · 2025-02-25T20:30:14Z

@mandrenguyen @antoniovilela could you merge these 3 PRs in order ?

first Implement additional framework integration tests #47425 (this PR)
then Modernise the interface of ObjectWithDict #47442 (once it's signed)
last Implement edm::ProductNamePattern #47444 (once it's signed)

?

Thanks !

mandrenguyen · 2025-02-25T20:50:10Z

+1

cmsbuild added this to the CMSSW_15_1_X milestone Feb 21, 2025

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending changes-dataformats labels Feb 21, 2025

cmsbuild added tests-started and removed tests-pending labels Feb 21, 2025

fwyzard mentioned this pull request Feb 21, 2025

Implement a GenericProduct and GenericCloner test module #46821

Open

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 21, 2025

cmsbuild added tests-approved and removed tests-started labels Feb 21, 2025

makortel reviewed Feb 21, 2025

View reviewed changes

fwyzard force-pushed the implement_framework_integration_tests branch from c997efb to dccffd1 Compare February 22, 2025 06:55

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Feb 22, 2025

cmsbuild added tests-started and removed tests-pending code-checks-pending labels Feb 22, 2025

Implement an integration test for post_insert()

60b81a3

fwyzard force-pushed the implement_framework_integration_tests branch from bf7ed8b to 60b81a3 Compare February 25, 2025 15:08

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Feb 25, 2025

cmsbuild added tests-started and removed tests-pending labels Feb 25, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 25, 2025

cmsbuild added tests-approved and removed tests-started labels Feb 25, 2025

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Feb 25, 2025

cmsbuild added orp-approved and removed orp-pending labels Feb 25, 2025

cmsbuild merged commit ad07505 into cms-sw:master Feb 25, 2025
19 of 20 checks passed

Implement additional framework integration tests #47425

Implement additional framework integration tests #47425

Uh oh!

Conversation

fwyzard commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

fwyzard commented Feb 21, 2025

Uh oh!

cmsbuild commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 21, 2025

Uh oh!

cmsbuild commented Feb 21, 2025

Uh oh!

cmsbuild commented Feb 21, 2025

Comparison Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fwyzard commented Feb 22, 2025

Uh oh!

cmsbuild commented Feb 22, 2025

Uh oh!

fwyzard commented Feb 25, 2025

Uh oh!

fwyzard commented Feb 25, 2025

Uh oh!

cmsbuild commented Feb 25, 2025

Uh oh!

cmsbuild commented Feb 25, 2025

Uh oh!

fwyzard commented Feb 25, 2025

Uh oh!

cmsbuild commented Feb 25, 2025

Comparison Summary

Uh oh!

makortel commented Feb 25, 2025

Uh oh!

makortel commented Feb 25, 2025

Uh oh!

cmsbuild commented Feb 25, 2025

Uh oh!

fwyzard commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mandrenguyen commented Feb 25, 2025

Uh oh!

Uh oh!

Uh oh!

fwyzard commented Feb 21, 2025 •

edited

Loading

cmsbuild commented Feb 21, 2025 •

edited

Loading

fwyzard commented Feb 25, 2025 •

edited

Loading