Adding `SimpleTrackValidation` Analyzer #47370

AdrianoDee · 2025-02-17T14:10:20Z

PR description:

This PR proposes to add the SimpleTrackValidation analyzer that, given in input:

a list of track collections;
a list of tracking particles (selected with a configurable TrackingParticleSelector);
a track associator;

produces a ROOT file collecting five quantities:

global_rt_, number of reconstructed tracks;
global_st_, number of tracking particles;
global_at_, number of reconstructed tracks associated to a tracking particle;
global_dt_, number of duplicates (number of sim associated to more than one reco);
global_ast_, number of tracking particles associated to at least a reconstructed track.

Used for the tracking performance optimization in:

This is useful as first step to include the optimizations scripts in cms-sw. Authored together with with @rsreds and @bucket420.

cmsbuild · 2025-02-17T14:10:42Z

cms-bot internal usage

cmsbuild · 2025-02-17T14:12:12Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47370/43726

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47370/43726/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47370/43726/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

AdrianoDee · 2025-02-17T14:27:41Z

please test

cmsbuild · 2025-02-17T14:29:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47370/43729

cmsbuild · 2025-02-17T14:30:09Z

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

Validation/RecoTrack (dqm)

@antoniovagnerini, @rseidita can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @missirol, @mmusich, @mtosi, @rovere, @wmtford this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2025-02-17T14:32:17Z

please test

mmusich

some pedantic comments (mostly care about the fillDescriptions)

Validation/RecoTrack/plugins/SimpleTrackValidation.cc

cmsbuild · 2025-02-17T16:38:06Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04317c/44431/summary.html
COMMIT: 3d21d55
CMSSW: CMSSW_15_1_X_2025-02-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47370/44431/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 4133522
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4133502
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 222 log files, 194 edm output root files, 51 DQM output files
TriggerResults: no differences found

SimpleTrackValidation Analyzer Co-authored-by: AdrianoDee <[email protected]> Co-authored-by: Simone Rossi Tisbeni <[email protected]> Co-authored-by: bucket420 <[email protected]>

cmsbuild · 2025-02-18T10:21:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47370/43753

cmsbuild · 2025-02-18T10:21:43Z

Pull request #47370 was updated. @antoniovagnerini, @cmsbuild, @rseidita can you please check and sign again.

AdrianoDee · 2025-02-18T11:24:24Z

please test

cmsbuild · 2025-02-18T13:32:41Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04317c/44464/summary.html
COMMIT: f208846
CMSSW: CMSSW_15_1_X_2025-02-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47370/44464/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 575 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 4133522
DQMHistoTests: Total failures: 2789
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4130713
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 222 log files, 194 edm output root files, 51 DQM output files
TriggerResults: no differences found

antoniovagnerini · 2025-02-18T13:53:57Z

+dqm

spurious differences seen in TrackerPhase2OTL1Track (open issue Non-reproducibility in TrackerPhase2OTL1Track #47071)
spurious differences seen from unstable WF 12834.7 (open issue spurious differences in outputs of Run-3 wfs *.7 #39803 )

cmsbuild · 2025-02-18T13:54:19Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2025-02-18T17:50:42Z

+1

mmusich · 2025-03-11T13:43:31Z

Validation/RecoTrack/plugins/SimpleTrackValidation.cc

+    int rt = 0;                    // number of reconstructed tracks;
+    int at = 0;                    // number of reconstructed tracks associated to a tracking particle
+    int ast = 0;                   // number of tracking particles associated to at least a reconstructed track.
+    int dt = 0;                    //  number of duplicates (number of sim associated to more than one reco);


global_dt_, number of duplicates (number of sim associated to more than one reco);

is this comment correct ?
dt is filled up in a loop on reco::Track-s, so this should be a number of reco tracks that is already been found associated to another sim track?
@elenavernazza @JanGerritSchulz @rovere

Indeed the comment is not right, this is counting the number of reco tracks associated to a sim track that has associations to multiple reco tracks (the logic to compute the duplicates should be fine, I think).

cmsbuild added this to the CMSSW_15_1_X milestone Feb 17, 2025

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Feb 17, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 17, 2025

AdrianoDee force-pushed the simple_validation branch from 8f2e620 to 3d21d55 Compare February 17, 2025 14:27

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 17, 2025

cmsbuild added tests-started and removed tests-pending labels Feb 17, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 17, 2025

mmusich reviewed Feb 17, 2025

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Feb 17, 2025

AdrianoDee force-pushed the simple_validation branch from 3d21d55 to 58e4d2f Compare February 18, 2025 10:14

cmsbuild added tests-pending and removed tests-approved code-checks-approved labels Feb 18, 2025

cmsbuild added the code-checks-rejected label Feb 18, 2025

This is a combination of 2 commits.

f208846

SimpleTrackValidation Analyzer Co-authored-by: AdrianoDee <[email protected]> Co-authored-by: Simone Rossi Tisbeni <[email protected]> Co-authored-by: bucket420 <[email protected]>

AdrianoDee force-pushed the simple_validation branch from b11f35a to f208846 Compare February 18, 2025 10:19

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 18, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 18, 2025

cmsbuild added tests-started and removed tests-pending labels Feb 18, 2025

cmsbuild added tests-approved and removed tests-started labels Feb 18, 2025

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Feb 18, 2025

cmsbuild added orp-approved and removed orp-pending labels Feb 18, 2025

cmsbuild merged commit 128089b into cms-sw:master Feb 18, 2025
11 checks passed

This was referenced Feb 19, 2025

Replace exit(x) with return x in ROOT macros #47391

Closed

Enable interop cms-sw/root#218

Closed

mmusich reviewed Mar 11, 2025

View reviewed changes

AdrianoDee deleted the simple_validation branch March 12, 2025 11:20

elenavernazza mentioned this pull request Jul 3, 2025

Add SimpleTrackValidation binned in eta and pt #48472

Open

Adding SimpleTrackValidation Analyzer #47370

Adding SimpleTrackValidation Analyzer #47370

Uh oh!

Conversation

AdrianoDee commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

Uh oh!

cmsbuild commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 17, 2025

Uh oh!

AdrianoDee commented Feb 17, 2025

Uh oh!

cmsbuild commented Feb 17, 2025

Uh oh!

cmsbuild commented Feb 17, 2025

Uh oh!

AdrianoDee commented Feb 17, 2025

Uh oh!

mmusich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmsbuild commented Feb 17, 2025

Comparison Summary

Uh oh!

cmsbuild commented Feb 18, 2025

Uh oh!

cmsbuild commented Feb 18, 2025

Uh oh!

AdrianoDee commented Feb 18, 2025

Uh oh!

cmsbuild commented Feb 18, 2025

Comparison Summary

Uh oh!

antoniovagnerini commented Feb 18, 2025

Uh oh!

cmsbuild commented Feb 18, 2025

Uh oh!

antoniovilela commented Feb 18, 2025

Uh oh!

Uh oh!

mmusich Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

AdrianoDee Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Adding `SimpleTrackValidation` Analyzer #47370

Adding `SimpleTrackValidation` Analyzer #47370

AdrianoDee commented Feb 17, 2025 •

edited

Loading

cmsbuild commented Feb 17, 2025 •

edited

Loading