Skip to content

Add SimpleTrackValidation binned in eta and pt #48472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elenavernazza
Copy link
Contributor

PR description:

This PR builds on top of #47370. It introduces two validation modules SimpleTrackValidationEtaBins.cc and SimpleTrackValidationPtBins.cc to compute the track efficiency and fake rates in bins of pt and eta. It can be used for the optimization of PixelTracks and GeneralTracks when interfaced with

https://github.com/cms-patatrack/The-Optimizer
https://github.com/cms-ngt-hlt/cms-reco-optimizer

PR validation:

The scripts can be validated by running the python configuration files available in the test folder:
Validation/RecoTrack/test/SimpleTrackValidationEtaBins_cfg.py
Validation/RecoTrack/test/SimpleTrackValidationPtBins_cfg.py

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48472/45398

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

A new Pull Request was created by @elenavernazza for master.

It involves the following packages:

  • Validation/RecoTrack (dqm)

@antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @missirol, @mmusich, @mtosi, @rovere, @wmtford this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jul 3, 2025

type ngt

@cmsbuild cmsbuild added the ngt label Jul 3, 2025
@mmusich
Copy link
Contributor

mmusich commented Jul 3, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48472/45401

Code check has found code style and quality issues which could be resolved by applying following patch(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants