Calo towers L1 scouting data format update #48093

tj710 · 2025-05-15T16:31:11Z

PR description:

We add new data formats for L1 Scouting, which will this year be collecting the L1 Calo Trigger 'towers', in addition to the contents of the previous years.

PR validation:

The tests are documented in /DataFormats/L1Scouting/test/TestL1ScoutingFormat.sh

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

We require backport to CMSSW 15_0_6

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2025-05-15T16:32:09Z

This PR contains too many commits (400 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

… and unpackers

cmsbuild · 2025-05-15T22:33:07Z

cms-bot internal usage

cmsbuild · 2025-05-15T22:34:20Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/44845

ERROR: Build errors found during clang-tidy run.

src/L1TriggerScouting/OnlineProcessing/plugins/ScoutingJetProducer.cc:13:10: error: 'FWCore/Utilities/interface/Span.h' file not found [clang-diagnostic-error]
   13 | #include "FWCore/Utilities/interface/Span.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Suppressed 833 warnings (833 in non-user code).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

DataFormats/L1Scouting/test/read_L1Scouting_cfg.py

cmsbuild · 2025-05-16T13:37:43Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/44855

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1Scouting/test/TestReadL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File DataFormats/L1Scouting/test/TestWriteL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/44855/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/44855/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2025-05-16T13:43:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/44856

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1Scouting/test/TestReadL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File DataFormats/L1Scouting/test/TestWriteL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2025-05-16T13:44:21Z

Pull request #48093 was updated.

mmusich · 2025-05-16T14:13:22Z

It would be good to update the title to reflect the actual changes proposed instead of the default branch title "Rebased" @tj710

mmusich · 2025-05-16T14:16:53Z

DataFormats/L1Scouting/test/TestL1ScoutingFormat.sh

+done
+
+# added Calo tower data format
+oldFiles="testL1Scouting_v3_v3_v3_v3_v3_v3_v3_15_0_1_split_99.root testL1Scouting_v3_v3_v3_v3_v3_v3_v3_15_0_1_split_0.root"


how is this supposed to work?
Does it need a new file to be stored in https://github.com/cms-data/DataFormats-L1Scouting ?

Hi Marco. Yes, it needs a new file in cms-data, is that repo managed or can I just commit to it? Thanks a lot.

Hi Thomas, you need to open a PR to that repo introducing the new file, then the two PRs can be tested together.

mmusich · 2025-05-16T14:17:13Z

EventFilter/L1ScoutingRawToDigi/plugins/ScCaloTowerRawToDigi.cc

+  descriptions.addDefault(desc);
+}
+
+DEFINE_FWK_MODULE(ScCaloTowerRawToDigi);


missing newline (pedantic)

cmsbuild · 2025-05-16T14:45:35Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/44857

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1Scouting/test/TestReadL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File DataFormats/L1Scouting/test/TestWriteL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/44857/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/44857/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild added this to the CMSSW_15_1_X milestone May 15, 2025

This was referenced May 15, 2025

Add storage tracer #48073

Merged

[NGT] Introduce NanoAOD flavour for Phase 2 HLT #48091

Merged

RoccoA97 and others added 6 commits May 16, 2025 00:30

Add support for CaloTower L1 Scouting with data format, blocks, masks…

d83cd2b

… and unpackers

Include new collection L1Scouting FastJet and producer

e786cd0

Fix wrong calo tower word masks

c4f70d5

Added tests for calo towers

158489d

Fixed L1 scouting OrbitCollection constructor

94004b7

updated CaloTowerMinSDSID and an argument in L1Scout file tests

cb130de

tj710 force-pushed the rebased branch from 34623be to cb130de Compare May 15, 2025 22:32

cmsbuild added l1-pending daq-pending pending-signatures tests-pending orp-pending code-checks-pending changes-dataformats labels May 15, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 15, 2025

missirol reviewed May 16, 2025

View reviewed changes

DataFormats/L1Scouting/test/read_L1Scouting_cfg.py Outdated Show resolved Hide resolved

removed include of depreciated edm::span

bd06f05

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 16, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 16, 2025

applied code format rules and fixed typo

731ffef

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 16, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels May 16, 2025

mmusich reviewed May 16, 2025

View reviewed changes

few fixes in the test code

22074e8

cmsbuild added code-checks-pending and removed code-checks-approved labels May 16, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 16, 2025

tj710 changed the title ~~Rebased~~ Calo towers L1 scouting data format update May 19, 2025

cmsbuild mentioned this pull request May 23, 2025

Introduce L1ScoutingNanoAOD for Run3 #48163

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Calo towers L1 scouting data format update #48093

Calo towers L1 scouting data format update #48093

Uh oh!

tj710 commented May 15, 2025

Uh oh!

cmsbuild commented May 15, 2025

Uh oh!

cmsbuild commented May 15, 2025 •

edited

Loading

Uh oh!

cmsbuild commented May 15, 2025

Uh oh!

Uh oh!

cmsbuild commented May 16, 2025

Uh oh!

cmsbuild commented May 16, 2025

Uh oh!

cmsbuild commented May 16, 2025

Uh oh!

mmusich commented May 16, 2025

Uh oh!

mmusich May 16, 2025

Uh oh!

tj710 May 19, 2025

Uh oh!

mmusich May 19, 2025

Uh oh!

mmusich May 16, 2025

Uh oh!

cmsbuild commented May 16, 2025

Uh oh!

Uh oh!

Calo towers L1 scouting data format update #48093

Are you sure you want to change the base?

Calo towers L1 scouting data format update #48093

Uh oh!

Conversation

tj710 commented May 15, 2025

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented May 15, 2025

Uh oh!

cmsbuild commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented May 15, 2025

Uh oh!

Uh oh!

cmsbuild commented May 16, 2025

Uh oh!

cmsbuild commented May 16, 2025

Uh oh!

cmsbuild commented May 16, 2025

Uh oh!

mmusich commented May 16, 2025

Uh oh!

mmusich May 16, 2025

Choose a reason for hiding this comment

Uh oh!

tj710 May 19, 2025

Choose a reason for hiding this comment

Uh oh!

mmusich May 19, 2025

Choose a reason for hiding this comment

Uh oh!

mmusich May 16, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented May 16, 2025

Uh oh!

Uh oh!

cmsbuild commented May 15, 2025 •

edited

Loading