Introduce L1ScoutingNanoAOD for Run3 #48163
Draft
+1,997
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48163/44934
|
|
enable nano |
|
please test |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43d56f/46799/summary.html This pull request cannot be automatically merged, could you please rebase it? |
patinkaew
force-pushed
the
l1scouting_nano_dev_15_1_0_pre3
branch
from
fe95b32 to
4fdcdbc
Compare
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-rejected
code-checks-approved
labels
|
Hi @ftorrresd, Sorry for a delay. I just fix the merge conflict. Please note that the workflow numbers for L1ScoutingNano have changed (since BPHNano workflow in 140X was removed in master). Best, |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48163/45278
|
ftorrresd
reviewed
Jun 23, 2025
| @@ -449,6 +461,8 @@ def subnext(self): | |||
| workflows[_wfn()] = ['lepTrackInfoNANOdata140Xrun3', ['MuonEG2024MINIAOD14.0', 'lepTrackInfoNANO_data14.0']] | |||
| workflows[_wfn()] = ['ScoutingNANOdata140Xrun3', ['ScoutingPFRun32024RAW14.0', 'scoutingNANO_data14.0']] | |||
| workflows[_wfn()] = ['ScoutingNANOwithPromptdata140Xrun3', ['ScoutingPFMonitor2024MINIAOD14.0', 'scoutingNANO_withPrompt_data14.0']] | |||
| workflows[_wfn()] = ['L1ScoutingNANOdata140Xrun3', ['L1Scouting2024RAW14.0', 'l1ScoutingNANO_data14.0']] | |||
| workflows[_wfn()] = ['L1ScoutingSelectionNANOdata140Xrun3', ['L1ScoutingSelection2024RAW14.0', 'l1ScoutingSelectionNANO_data14.0']] | |||
There was a problem hiding this comment.
Looks like these two lines overflow the WF counter.
My naive suggestion for now would be to move the L1Scounting to a new series (2500.28x). I also leave it for the others to comment.
There was a problem hiding this comment.
@patinkaew -- please, have a look at #48459
There was a problem hiding this comment.
@ftorrresd thank you!
Sorry for a late reply, we had a discussion during L1Scouting Weekly today also and we are fine with moving to a new series. However, I think the new PR to extend the workflow numbers can work really well also. I will keep on eye on #48459 and once that is merged, I will rebase this PR.
patinkaew
force-pushed
the
l1scouting_nano_dev_15_1_0_pre3
branch
from
4fdcdbc to
a7823dc
Compare
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-approved
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48163/45425
|
|
Pull request #48163 was updated. |
|
Hi @ftorrresd, I saw #48459 was merged. I didn't see any merge conflict, but I just rebased to the latest IB release anyway. The workflow numbers for L1ScoutingNano are now We discussed this PR in the L1Scouting meeting last week and other people from L1Scouting are reviewing this. Once the reviewers give a green light, I will change this PR to be ready for review so we can merge soon. Best regards, |
|
please test |
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Please also note contributions from @gpetruc, @Mmiglio for initial and important components of L1ScoutingNano as well as L1Scouting team for numerous valuable feedbacks.
This PR introduces L1ScoutingNanoAOD workflow for Run3. For L1Scouting data, each processing event is actually an orbit (in OrbitCollection), different OutputModule is needed to convert orbits to bunch crossings (bx).
Some key features:
OrbitNanoAODOutputModuleis analogous toNanoAODOutputModuleand is used to convert orbits to bxs.OrbitFlatTableis analogous tonanoaod::FlatTableand contains offsets of each bx in an orbitSimpleOrbitFlatTableProduceris analogous toSimpleFlatTableProducerand has all functionalities ofSimpleFlatTableProducer.Two custom NanoAOD flavours are added:
@L1Scoutfor ZeroBias stream and@L1ScoutSelectfor Selection stream.Event content files (html) can be found here on CERNBOX.
PR validation:
Pass all tests from
scram b runtests use-ibeos.Two relval_nano workflows are added for each flavour.
Pass these two workflows from
runTheMatrix.py -l 2500.240,2500.241If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is not a backport.