-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Use RNTuple output module for NanoAOD #48162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48162/44933
|
A new Pull Request was created by @ariostas for master. It involves the following packages:
@antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
2a78e72
to
3ee8c18
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48162/44994 |
Pull request #48162 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please check and sign again. |
3ee8c18
to
2b06b73
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48162/44995 |
Pull request #48162 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please check and sign again. |
In the last commit I made it so that the |
The CppType='PoolOutputModule'
if self._options.rntuple_out:
CppType='RNTupleOutputModule'
fileName = fileName.replace('.root', '.rntpl')
if self._options.timeoutOutput:
CppType='TimeoutPoolOutputModule'
fileName = fileName.replace('.rntpl', '.root')
if streamType=='DQM' and tier=='DQMIO':
CppType='DQMRootOutputModule'
fileName = fileName.replace('.rntpl', '.root')
if not ignoreNano and "NANOAOD" in streamType:
CppType='NanoAODRNTupleOutputModule' if self._options.rntuple_out else 'NanoAODOutputModule' |
2b06b73
to
fd81f2e
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48162/45282 |
Pull request #48162 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please check and sign again. |
please test |
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test TestConfigurationApplicationsConfigBuilder had ERRORS Comparison SummarySummary:
|
3b2dd8f
to
b92bac1
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48162/45291 |
Pull request #48162 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please check and sign again. |
please test |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
This PR adjusts the
ConfigBuilder.py
script so thatNanoAODRNTupleOutputModule
is used when the--rntuple_out
flag is passed.This is thanks to @makortel's help in #48071 (comment). I checked that this change works with #48071.