-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[backport of #48201 to 15_0_X] PPS Diamond DQM Local Coordinate System Enhancement #48234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport of #48201 to 15_0_X] PPS Diamond DQM Local Coordinate System Enhancement #48234
Conversation
A new Pull Request was created by @grzanka for CMSSW_15_0_X. It involves the following packages:
@antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
please test |
backport of #48201 |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
+dqm |
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR Description:
Backport of #48201
This PR adjusts the CTPPS Diamond DQM plots to handle the rotation of Roman Pots equipped with timing detectors. Hit and track positions are now correctly transformed from the global to the local coordinate system.
The changes include:
PR Validation:
The code has been tested with recent data (run 391514, 10k events) and produces accurate plots of diamond hits and tracks.
Left plot - after this PR, right plots - before.



Tests with run 385481 (from 2024) were performed to ensure backward compatibility.
Additionally,
runTheMatrix
was executed with workflows 1045, 1046, and 1047.