Skip to content

[backport of #48201 to 15_0_X] PPS Diamond DQM Local Coordinate System Enhancement #48234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented Jun 3, 2025

PR Description:

Backport of #48201

This PR adjusts the CTPPS Diamond DQM plots to handle the rotation of Roman Pots equipped with timing detectors. Hit and track positions are now correctly transformed from the global to the local coordinate system.

The changes include:

  • Updated hit position calculations to properly account for rotated diamond detectors in all relevant plots.
  • Adjusted the Y-axis range for pixel-related plots from (-8, 8) to (-6, 18) to better match the actual detector coverage.
  • Extended geometry information storage to include rotations, translations, and diamond half-widths.

PR Validation:

The code has been tested with recent data (run 391514, 10k events) and produces accurate plots of diamond hits and tracks.

Left plot - after this PR, right plots - before.
image
image
image

Tests with run 385481 (from 2024) were performed to ensure backward compatibility.

image
image

Additionally, runTheMatrix was executed with workflows 1045, 1046, and 1047.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2025

A new Pull Request was created by @grzanka for CMSSW_15_0_X.

It involves the following packages:

  • DQM/CTPPS (dqm)

@antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please review it and eventually sign? Thanks.
@fabferro this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2025

cms-bot internal usage

@antoniovagnerini
Copy link

please test

@mmusich
Copy link
Contributor

mmusich commented Jun 5, 2025

backport of #48201

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1546a/46561/summary.html
COMMIT: 95b37ce
CMSSW: CMSSW_15_0_X_2025-06-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48234/46561/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4005105
  • DQMHistoTests: Total failures: 68
  • DQMHistoTests: Total nulls: 142
  • DQMHistoTests: Total successes: 4004875
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 276.75 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 6.750 KiB CTPPS/TimingDiamond
  • DQMHistoSizes: changed ( 11634.0,... ): 13.500 KiB CTPPS/TimingDiamond
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 638ffd3 into cms-sw:CMSSW_15_0_X Jun 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants