PPS Diamond DQM Local Coordinate System Enhancement

[grzanka]

PR Description:

This PR adjusts the CTPPS Diamond DQM plots to handle the rotation of Roman Pots equipped with timing detectors. Hit and track positions are now correctly transformed from the global to the local coordinate system.

The changes include:

• Updated hit position calculations to properly account for rotated diamond detectors in all relevant plots.
• Adjusted the Y-axis range for pixel-related plots from (-8, 8) to (-6, 18) to better match the actual detector coverage.
• Extended geometry information storage to include rotations, translations, and diamond half-widths.

PR Validation:

The code has been tested with recent data (run 391514, 10k events) and produces accurate plots of diamond hits and tracks.

Left plot - after this PR, right plots - before.

Tests with run 385481 (from 2024) were performed to ensure backward compatibility.

Additionally, runTheMatrix was executed with workflows 1045, 1046, and 1047.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48201/44977

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48201/44977/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48201/44977/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48201/44979

[cmsbuild]

A new Pull Request was created by @grzanka for master.

It involves the following packages:

• DQM/CTPPS (dqm)

@antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please review it and eventually sign? Thanks.
@fabferro this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48201/44999

[cmsbuild]

Pull request #48201 was updated. @antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please check and sign again.

[antoniovagnerini]

please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2487fc/46495/summary.html
COMMIT: beee2c5
CMSSW: CMSSW_15_1_X_2025-06-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48201/46495/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4041171
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 142
• DQMHistoTests: Total successes: 4040990
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 263.25 KiB( 49 files compared)
• DQMHistoSizes: changed ( 10224.0,... ): 6.750 KiB CTPPS/TimingDiamond
• DQMHistoSizes: changed ( 11634.0,... ): 13.500 KiB CTPPS/TimingDiamond
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[antoniovagnerini]

+dqm

• spurious differences from unstable WF 29834.999(open issue Non-reproducibility in TrackerPhase2OTL1Track #47071)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[mandrenguyen]

+1