PPS: Increase X-axis range for "RP State per Lumisection" DQM plot to 3000 LS #48426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48426/45334 |
|
A new Pull Request was created by @grzanka for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
In recent weeks, we've observed data-taking runs extending beyond 1000 lumisections (LS). This pull request addresses this by enlarging the lumisection scale to 3000 for the "rpstate per LS" plot within the CTPPS (PPS) DQM.
Previously, an attempt was made in #48201 to use
hist->SetCanExtend(TH2F::kXaxis);to allow for an automatically extending X-axis when more than 1000 LS were recorded. However, this approach did not work as expected, and the X-axis remained limited to a fixed range.This PR implements a direct increase of the X-axis range to 3000 LS, ensuring that lumisections in longer runs are properly displayed and monitored. While this is a hardcoded solution, it's crucial for us to avoid the current 1000 LS limitation. We are open to alternative solutions that offer a more dynamic or automatic axis extension in the future.
PR validation:
Private DQM production.