Skip to content

add phase-2 NANO HLT workflows to ph2_hlt short matrix #48262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 6, 2025

PR description:

Title says it all, it's a follow-up to PRs #48091 and #48076.
Add the workflows added in #48091 to the ph2_hlt short matrix and exercise them in IBs.

PR validation:

runTheMatrix.py -l ph2_hlt runs.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@elenavernazza FYI

@cmsbuild cmsbuild added this to the CMSSW_15_1_X milestone Jun 6, 2025
@mmusich
Copy link
Contributor Author

mmusich commented Jun 6, 2025

test parameters:

  • workflows = ph2_hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

Pull request #48262 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jun 6, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

-1

Failed Tests: RelVals
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64d208/46576/summary.html
COMMIT: 00074a1
CMSSW: CMSSW_15_1_X_2025-06-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48262/46576/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 29834.759, 29834.771

@mmusich mmusich force-pushed the mm_dev_addWFstoPh2HLT branch from 00074a1 to 4b5860b Compare June 6, 2025 13:11
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

Pull request #48262 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jun 6, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64d208/46579/summary.html
COMMIT: 4b5860b
CMSSW: CMSSW_15_1_X_2025-06-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48262/46579/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 60
  • DQMHistoTests: Total histograms compared: 4304812
  • DQMHistoTests: Total failures: 83
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4304709
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 59 files compared)
  • Checked 245 log files, 204 edm output root files, 60 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jun 11, 2025

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 kind ping, thank you.

@AdrianoDee
Copy link
Contributor

+pdmv

@Moanwar
Copy link
Contributor

Moanwar commented Jun 11, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cb987a3 into cms-sw:master Jun 11, 2025
11 checks passed
@mmusich mmusich deleted the mm_dev_addWFstoPh2HLT branch June 11, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants