Skip to content

[15.0.X] apply stage2 L1T customizations to TrackToTrackComparisonHists #48457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: CMSSW_15_0_X
Choose a base branch
from

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 1, 2025

backport of #48440

PR description:

Title say it all, similar in spirit to #37033.
See also #37016.

PR validation:

The following script:

#!/bin/bash -ex

cmsDriver.py step2 -s HLT:@relval2025,DQM:hltToOfflineTrackValidatorSequence \
         --conditions 150X_dataRun3_HLT_v1 \
         --datatier DQMIO \
         -n 100 \
         --eventcontent DQMIO \
         --geometry DB:Extended \
         --era Run3_2025 \
         --filein file:/eos/cms/store/express/Run2025C/HLTMonitor/FEVTHLTALL/Express-v2/000/393/240/00000/04d4a103-3bea-43b3-84b0-b68954534572.root \
         --fileout file:step2.root \
         --nThreads 24 \
         --process HLTX \
         --inputCommands='keep *, drop *_hlt*_*_HLT, drop triggerTriggerFilterObjectWithRefs_l1t*_*_HLT' \
         > step2.log  2>&1

cmsDriver.py step3 -s HARVESTING:trackEfficiencyMonitoringClientHLT \
         --conditions 150X_dataRun3_HLT_v1 \
         --data \
         --geometry DB:Extended \
         --scenario pp \
         --filetype DQM \
         --era Run3_2025 \
         -n -1  \
         --filein file:step2.root \
         --fileout file:step3.root > step3.log  2>&1

completes successfully, while in the vanilla release it fails with:

----- Begin Fatal Exception 29-Jun-2025 18:26:46 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 393240 stream: 21
   [1] Calling method for module TrackToTrackComparisonHists/'hltEgammaGsfTracksVsOfflinePV'
Exception Message:
No "L1GtStableParametersRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Now clearly in presence of the Run3_2025 the cmsRun configuration should not request to use Legacy Stage-0/1 Global Trigger records.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #48440 to CMSSW_15_0_X for 2025 data-taking operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2025

A new Pull Request was created by @mmusich for CMSSW_15_0_X.

It involves the following packages:

  • DQM/TrackingMonitorSource (dqm)

@antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please review it and eventually sign? Thanks.
@VinInn, @VourMa, @arossi83, @fioriNTU, @idebruyn, @jandrea, @mmusich, @mtosi, @richa2710, @sroychow, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2025

cms-bot internal usage

@rseidita
Copy link
Contributor

rseidita commented Jul 1, 2025

please test

@mmusich
Copy link
Contributor Author

mmusich commented Jul 1, 2025

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bda693/47037/summary.html
COMMIT: 905bc17
CMSSW: CMSSW_15_0_X_2025-07-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48457/47037/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4124252
  • DQMHistoTests: Total failures: 7422
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4116810
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 222 log files, 194 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 1 / 49 workflows

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants