Skip to content

Change fromVertex parameter from False to True for DGL reconstruction #48475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2025

Conversation

CeliaFernandez
Copy link
Contributor

PR description:

This PR issue intends to address the reported inefficiency of displaced muons found at low pt.
A deficit of displaced global muons (DGL) for pt < 50 GeV in the barrel region has been reported.
Problem was tracked down to muons reconstructed with the displaced track algorithm = 14 which makes use of the OutsideInMuonSeeder.cc and most specifically the FromVertex parameter that is set to False for DGLs.
A fix for this muons is proposed and consists on setting FromVertex = True consistently in the algorithms used to reconstruct the DGLs.

This PR is backed up by the studies done in the context of a Run 3 dedicated displaced muon analysis (see some of the contacts below). More information can be found in the following presentations:

The plan is to merge this in 15_1 and then backport it to 15_0.

For the validation of this PR, we anticipate an increase of muons at low pt in reco::Track displacedGlobalMuons, reco::Muon displacedMuons and reco::Muon slimmedDisplacedMuons.

Contacts: @aescalante @24LopezR @bonanomi

PR validation:

We have a clean build and unit tests pass.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is NOT a backport, but we are planning to do one for 15_0.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

A new Pull Request was created by @CeliaFernandez for master.

It involves the following packages:

  • RecoMuon/Configuration (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @HuguesBrun, @abbiendi, @andrea21z, @bellan, @cericeci, @jhgoh, @missirol, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 3, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ef0ba/47072/summary.html
COMMIT: f97d357
CMSSW: CMSSW_15_1_X_2025-07-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48475/47072/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@CeliaFernandez
Copy link
Contributor Author

Hi @jfernan2 , the residual changes observed in the displaced muons collections are consistent with the expectations reported in the attached presentations. We were wondering if we could trigger the tests on 1355.0 and 140.109 additionally? Just to cross-check if the effect is more visible there.

Thank you in advance! :)

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 4, 2025

please test workflow 1355.0,140.109

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ef0ba/47081/summary.html
COMMIT: f97d357
CMSSW: CMSSW_15_1_X_2025-07-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48475/47081/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@CeliaFernandez
Copy link
Contributor Author

Thank you, I think the results make sense looking at the stats.

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 4, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 10b6858 into cms-sw:master Jul 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants