-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Change fromVertex parameter from False to True for DGL reconstruction #48475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48475/45402 |
A new Pull Request was created by @CeliaFernandez for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
Hi @jfernan2 , the residual changes observed in the displaced muons collections are consistent with the expectations reported in the attached presentations. We were wondering if we could trigger the tests on 1355.0 and 140.109 additionally? Just to cross-check if the effect is more visible there. Thank you in advance! :) |
please test workflow 1355.0,140.109 |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
Thank you, I think the results make sense looking at the stats. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR issue intends to address the reported inefficiency of displaced muons found at low pt.
A deficit of displaced global muons (DGL) for pt < 50 GeV in the barrel region has been reported.
Problem was tracked down to muons reconstructed with the displaced track algorithm = 14 which makes use of the OutsideInMuonSeeder.cc and most specifically the FromVertex parameter that is set to False for DGLs.
A fix for this muons is proposed and consists on setting
FromVertex = True
consistently in the algorithms used to reconstruct the DGLs.This PR is backed up by the studies done in the context of a Run 3 dedicated displaced muon analysis (see some of the contacts below). More information can be found in the following presentations:
The plan is to merge this in 15_1 and then backport it to 15_0.
For the validation of this PR, we anticipate an increase of muons at low pt in
reco::Track displacedGlobalMuons
,reco::Muon displacedMuons
andreco::Muon slimmedDisplacedMuons
.Contacts: @aescalante @24LopezR @bonanomi
PR validation:
We have a clean build and unit tests pass.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is NOT a backport, but we are planning to do one for 15_0.