Skip to content

Backport to change fromVertex parameter from False to True for DGL reconstruction #48476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: CMSSW_15_0_X
Choose a base branch
from

Conversation

CeliaFernandez
Copy link
Contributor

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #48475 for 15.0. Description of changes can be found there.

Since the timeline for this PR it's tight, we prepared it in parallel with the main PR to speed up the review process. Changes (if any) will be integrated in parallel.

Thank you!

FYI: @aescalante @bonanomi @24LopezR @llunerti

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

A new Pull Request was created by @CeliaFernandez for CMSSW_15_0_X.

It involves the following packages:

  • RecoMuon/Configuration (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @HuguesBrun, @abbiendi, @andrea21z, @bellan, @cericeci, @jhgoh, @missirol, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

cms-bot internal usage

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 3, 2025

please test

@vlimant
Copy link
Contributor

vlimant commented Jul 3, 2025

assign ppd

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

New categories assigned: ppd

@malbouis,@vlimant you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71b6df/47073/summary.html
COMMIT: 530c9d9
CMSSW: CMSSW_15_0_X_2025-07-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48476/47073/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2632 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4009944
  • DQMHistoTests: Total failures: 619
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4009305
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 4, 2025

please test workflow 1355.0,140.109

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71b6df/47082/summary.html
COMMIT: 530c9d9
CMSSW: CMSSW_15_0_X_2025-07-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48476/47082/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 4, 2025

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants