-
Notifications
You must be signed in to change notification settings - Fork 4.5k
add DQM plots for new CMS-FSC detector #48487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48487/45415 |
A new Pull Request was created by @michael-pitt for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
Thanks @michael-pitt , To add from the side of ZDC software, I have tested this PR (see tests documented in this dropbox paper). In these tests I have confirmed that both (A) FSC information appears as expected and (B) no ZDC information is modified as a result. A future improvement could be to make it clear in the DQM that these are FSC channels (currently they are marked as included in the emap, which labels it as EM). This change is not necessary to merge this PR and can be done at a later date. |
Also tagging colleagues from HIN: @mandrenguyen |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
@hjbossi @michael-pitt please open the backport to 15_0_X as well |
+1 |
+dqm
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
New DQM plots for additional channels, corresponding to Forward Shower Counters (FSC), that were introduced in June 2025 in the Heavy Ion program.
The FSC counters are treated as additional EM channels. The code automatically reads these channels once a new emap is loaded.
The code only extends the histogram booking for additional EM channels, and excludes these channels from being filled in the sums. Hence, the only change will be in the addition of the 6 EM channels to the DQM w/o modifying the content of all the rest (including sums).
PR validation:
Validated with
CMSSW_15_0_9_patch3
with replacing the offlineHcalElectronicsMap_v10.0_offline
with newemap_2025_full.txt
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR needs to be backported to 15_0_X for July NeNe collisions