Skip to content

add DQM plots for new CMS-FSC detector #48487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

michael-pitt
Copy link
Contributor

PR description:

New DQM plots for additional channels, corresponding to Forward Shower Counters (FSC), that were introduced in June 2025 in the Heavy Ion program.

The FSC counters are treated as additional EM channels. The code automatically reads these channels once a new emap is loaded.

The code only extends the histogram booking for additional EM channels, and excludes these channels from being filled in the sums. Hence, the only change will be in the addition of the 6 EM channels to the DQM w/o modifying the content of all the rest (including sums).

PR validation:

Validated with CMSSW_15_0_9_patch3 with replacing the offline HcalElectronicsMap_v10.0_offline with new emap_2025_full.txt

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR needs to be backported to 15_0_X for July NeNe collisions

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2025

A new Pull Request was created by @michael-pitt for master.

It involves the following packages:

  • DQM/HcalTasks (dqm)

@antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please review it and eventually sign? Thanks.
@DryRun, @abdoulline, @bsunanda, @denizsun, @salimcerci this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@rseidita
Copy link
Contributor

rseidita commented Jul 6, 2025

Please test

@hjbossi
Copy link
Contributor

hjbossi commented Jul 6, 2025

Thanks @michael-pitt , To add from the side of ZDC software, I have tested this PR (see tests documented in this dropbox paper). In these tests I have confirmed that both (A) FSC information appears as expected and (B) no ZDC information is modified as a result.

A future improvement could be to make it clear in the DQM that these are FSC channels (currently they are marked as included in the emap, which labels it as EM). This change is not necessary to merge this PR and can be done at a later date.

@hjbossi
Copy link
Contributor

hjbossi commented Jul 6, 2025

Also tagging colleagues from

HIN: @mandrenguyen
HCAL: @salimcerci, @denizsun, @abdoulline, @akhukhun

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-95a47e/47094/summary.html
COMMIT: 8f04fe4
CMSSW: CMSSW_15_1_X_2025-07-06-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48487/47094/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4067201
  • DQMHistoTests: Total failures: 23
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4067158
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@rseidita
Copy link
Contributor

rseidita commented Jul 7, 2025

@hjbossi @michael-pitt please open the backport to 15_0_X as well

@mandrenguyen
Copy link
Contributor

+1

@rseidita
Copy link
Contributor

rseidita commented Jul 7, 2025

+dqm

  • P5 tests OK

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 21e9587 into cms-sw:master Jul 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants