Skip to content

[15_0_X]:Add FSC to the DQM. #48489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Conversation

hjbossi
Copy link
Contributor

@hjbossi hjbossi commented Jul 7, 2025

PR description:

New DQM plots for additional channels, corresponding to Forward Shower Counters (FSC), that were introduced in June 2025 in the Heavy Ion program.

The FSC counters are treated as additional EM channels. The code automatically reads these channels once a new emap is loaded.

The code only extends the histogram booking for additional EM channels, and excludes these channels from being filled in the sums. Hence, the only change will be in the addition of the 6 EM channels to the DQM w/o modifying the content of all the rest (including sums).

PR validation:

This PR was validated using the procedure described in the dropbox (here) and using the online playback.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #48487 and is meant to be incorporated as soon as possible during the light ion data-taking.

Also tagging colleagues from

DQM: @rseidita
HIN: @mandrenguyen
HCAL: @salimcerci, @denizsun, @abdoulline, @akhukhun

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2025

A new Pull Request was created by @hjbossi for CMSSW_15_0_X.

It involves the following packages:

  • DQM/HcalTasks (dqm)

@antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please review it and eventually sign? Thanks.
@DryRun, @abdoulline, @bsunanda, @denizsun, @salimcerci this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2025

cms-bot internal usage

@rseidita
Copy link
Contributor

rseidita commented Jul 7, 2025

backport of #48487

@rseidita
Copy link
Contributor

rseidita commented Jul 7, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8413a1/47104/summary.html
COMMIT: 2847f53
CMSSW: CMSSW_15_0_X_2025-07-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48489/47104/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4009944
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4009914
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@rseidita
Copy link
Contributor

rseidita commented Jul 7, 2025

+dqm

  • P5 tests OK

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 35c2166 into cms-sw:CMSSW_15_0_X Jul 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants