-
Notifications
You must be signed in to change notification settings - Fork 69
Code cleanup and fixed some typos #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
510fc78
made some micro optimizations to some functions
1126e03
fixed a small typo
f2174de
fixed a small typo
8606b28
fixed some small typos
a1b7e64
fixed some small typos
613f548
fixed a small typo
a9a9964
fixed a small typo
62988fc
fixed a small typo
42410cd
fixed the formatting of an if statement
813ac01
removed the comment
ebfd82e
revert this change to see if it fixes the failing check
65dde85
fixed some typos
81b2c3d
fixed some typos
036793a
fixed some typos
34d204c
fixed some typos
2043f45
fixed some typos
4b81514
fixed some typos
f4b9c3a
fixed some small typos
31726ff
fixed some typos
76ba3cc
revert the index filename change to make the buildwin test happy
dd1ffdc
Merge branch 'master' into master
W2Wizard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
/* By: W2Wizard <[email protected]> +#+ */ | ||
/* +#+ */ | ||
/* Created: 2021/12/28 01:53:51 by W2Wizard #+# #+# */ | ||
/* Updated: 2022/07/21 10:34:36 by sbos ######## odam.nl */ | ||
/* Updated: 2022/11/22 08:35:42 by jvan-hal ######## odam.nl */ | ||
/* */ | ||
/* ************************************************************************** */ | ||
|
||
|
@@ -18,8 +18,9 @@ int32_t mlx_lstsize(mlx_list_t* lst) | |
{ | ||
int32_t i = 0; | ||
|
||
if (!lst) | ||
/*if (!lst) | ||
return (i); | ||
this check isn't necessary since the while loop won't execute when lst is NULL*/ | ||
while (lst) | ||
{ | ||
i++; | ||
|
@@ -62,12 +63,10 @@ mlx_list_t* mlx_lstnew(void* content) | |
|
||
mlx_list_t* mlx_lstlast(mlx_list_t* lst) | ||
{ | ||
while (lst) | ||
{ | ||
if (!lst->next) | ||
break; | ||
if (!lst) | ||
return (NULL); | ||
while (lst->next) | ||
lst = lst->next; | ||
} | ||
return (lst); | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If thats the case just remove the section of code as well as the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coming up