Skip to content

Code cleanup and fixed some typos #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 24, 2022
Merged

Code cleanup and fixed some typos #63

merged 21 commits into from
Nov 24, 2022

Conversation

Jeroenvh99
Copy link
Contributor

I reverted all the changes that weren't linked list related from my last PR, it's ok now.

W2Wizard
W2Wizard reviewed Nov 22, 2022
View reviewed changes
src/utils/mlx_list.c Outdated
return (i);
this check isn't necessary since the while loop won't execute when lst is NULL*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If thats the case just remove the section of code as well as the comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coming up

@W2Wizard W2Wizard changed the title Some micro optimizations to the linked list functions and fixed some typos Code cleanup and fixed some typos Nov 22, 2022
@W2Wizard W2Wizard added Documentation Improvements or additions to documentation Fix Fixed or resolved an issue labels Nov 22, 2022
@Jeroenvh99
Copy link
Contributor Author

Jeroenvh99 commented Nov 22, 2022 •
edited
Loading

I honestly don't know why the build-win test is failing when I change if (*out) *out[0] = '\0'; to if (*out) *out[0] = '\0'; divided over two lines this other formatting of the if statement doesn't change the code right?

@Jeroenvh99
Copy link
Contributor Author

I looked through all of the documentation and fixed most of the typos I came across

@W2Wizard
Copy link
Collaborator

W2Wizard commented Nov 24, 2022 •
edited
Loading

@Jeroenvh99 The Windows build error is not because of you, its because the thing I use to download MinGW in the CI is a bit broken. I just haven't had the time to come with an alternative.

See: egor-tensin/setup-mingw#9 (comment)

@Jeroenvh99
Copy link
Contributor Author

Jeroenvh99 commented Nov 24, 2022 •
edited
Loading

Good to know, I can look into how to fix that later. In what file is the script for this check located, then I'll look into a fix today?

@W2Wizard
Copy link
Collaborator

Great PR! Thanks so much for your time and effort 😄
Checked all the things, i'm happy with this.

@W2Wizard W2Wizard merged commit e7f7089 into codam-coding-college:master Nov 24, 2022
@Jeroenvh99
Copy link
Contributor Author

Happy to hear that

@Jeroenvh99 Jeroenvh99 mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W2Wizard W2Wizard W2Wizard left review comments

Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation Fix Fixed or resolved an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeroenvh99 @W2Wizard