try to fix the buildwin check #67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is not because the code is failing it. Its because the CI is just a bit roughly implemented. I'm planning / working on something to do about it in the near future. Also, please update your fork by fetching from upstream and avoid using master, make a new branch for PRs instead. |
|
ah, it's because of that, I was already getting very confused why the build-win check passed this time because I changed the same piece of code that broke the build-win check last time. I'll make a new branch next time, that's better indeed. |
|
I'll close this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as @W2Wizard mentioned here #63 (comment), the thing that downloads mingw for the buildwin check is kinda broken, this is my attempt to fix it