fix: device callback URL needs to handle a /#4448
Merged
Merged
Conversation
If the issuer path ends with a / the URL will be built wrong so we should instead use the helper function to ensure the path is built correctly. fixes dexidp#4242. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
cardoe
force-pushed
the
fix-device-callback-url
branch
from
cb3f8a0 to
d38247a
Compare
Contributor
Author
|
This is part of my v2.44.90 testing build. |
nabokihms
approved these changes
Jan 13, 2026
Member
|
Thanks, good catch! |
yardenshoham
pushed a commit
to yardenshoham/dex
that referenced
this pull request
Jan 29, 2026
If the issuer path ends with a / the URL will be built wrong so we should instead use the helper function to ensure the path is built correctly. fixes dexidp#4242. Signed-off-by: Doug Goldstein <cardoe@cardoe.com> Signed-off-by: Yarden Shoham <git@yardenshoham.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the issuer path ends with a / the URL will be built wrong so we should instead use the helper function to ensure the path is built correctly. fixes #4242.