Skip to content

Prefer use of Interpolated strings in project Presentation #8519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

halgab
Copy link
Contributor

@halgab halgab commented Dec 8, 2023

Sorry, this PR is massive. But I'm not sure how to break it down as it contains mostly automated changes.

Description

We replace as many manual string concatenations and string.Format with interpolated strings. This saves allocations in many instances, and makes for a more readable code.

Customer Impact

Less allocations

Regression

No

Testing

CI

Risk

Low. Most changes are automated using the IDE

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned halgab Dec 8, 2023
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Dec 8, 2023
@ghost ghost requested review from dipeshmsft and singhashish-wpf December 8, 2023 15:19
@ghost ghost added the Community Contribution A label for all community Contributions label Dec 8, 2023
@halgab halgab force-pushed the interpolated-string-presentation branch from 93ef355 to 2e6ca60 Compare December 8, 2023 15:45
@ghost ghost added the draft label Dec 8, 2023
@halgab halgab force-pushed the interpolated-string-presentation branch from 2e6ca60 to b156b3c Compare December 8, 2023 16:21
@halgab halgab marked this pull request as ready for review December 8, 2023 17:13
@halgab halgab requested a review from a team as a code owner December 8, 2023 17:13
@ghost ghost removed the draft label Dec 8, 2023
@halgab halgab force-pushed the interpolated-string-presentation branch from b156b3c to bd06576 Compare December 10, 2023 20:36
@halgab halgab force-pushed the interpolated-string-presentation branch from bd06576 to 28eea76 Compare December 11, 2023 15:49
@rchauhan18
Copy link
Contributor

Thanks @halgab for the contribution!

@halgab halgab deleted the interpolated-string-presentation branch January 10, 2024 09:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants