Prefer use of interpolated strings in System.Xaml #8615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
ghost
requested review from
halgab
changed the title
rchauhan18
previously approved these changes
Jan 18, 2024
|
I've just noticed there are merge conflicts. I'll try to resolve them by the end of the day |
halgab
force-pushed
the
interpolated-string-xaml
branch
from
b5ded84 to
6d5f2bf
Compare
halgab
force-pushed
the
interpolated-string-xaml
branch
from
6d5f2bf to
8e62344
Compare
dipeshmsft
reviewed
Aug 26, 2024
src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/InfosetObjects/XamlNodes.cs
Outdated
Show resolved
Hide resolved
dipeshmsft
approved these changes
Aug 27, 2024
dipeshmsft
added
Included in test pass
and removed
Queue for test pass
Status:Committed
labels
|
@halgab Thank you for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8519
Description
We replace as many manual string concatenations and string.Format with interpolated strings. This saves allocations in many instances, and makes for a more readable code.
Customer Impact
Less allocations
Regression
No
Testing
CI
Risk
Low. Most changes are automated using the IDE
Microsoft Reviewers: Open in CodeFlow