[CI] BK Vault plugin for EC access #8377

pazone · 2025-06-06T11:10:14Z

What does this PR do?

Introduces BK Vault plugin. Simplifies EC access and prevents possible issues
Windows retry tested in this build

Why is it important?

Checklist

I have read and understood the pull request guidelines of this project.
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in ./changelog/fragments using the changelog tool
I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

How are we going to support this in production?
How are we going to measure its adoption?
How are we going to debug this?
What are the metrics I should take care of?
...

mergify · 2025-06-06T11:10:56Z

This pull request does not have a backport label. Could you fix it @pazone? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

v1v

I really like this approach, so it helps to document the consumers and reduce the overhead in the scripts, those scripts should run in a configured environment for simplicity.

I left a few comments

.buildkite/bk.integration.pipeline.yml

.buildkite/scripts/steps/ess.sh

v1v

Overall, it looks good to me. However, I have a few comments:

There is a question regarding the inclusion of the environment in the name of the anchor plugin ID.
Please utilize the GitHub issue related to the OGC replacement to provide additional context.
Make sure to include the removed plugin in one of the steps.

.buildkite/bk.integration.pipeline.yml

.buildkite/hooks/pre-command

.buildkite/bk.integration.pipeline.yml

v1v

LGTM, thanks Pavel!

v1v · 2025-06-16T15:12:10Z

I think there are missing changes in some other pipelines:

Start ESS stack for FIPS integration tests
source .buildkite/scripts/steps/ess_start.sh

See https://github.com/elastic/elastic-agent/blob/main/.buildkite/bk.integration-fips.pipeline.yml

…ault_plugin

pazone · 2025-06-16T15:21:16Z

Updated the FIPS pipeline

elastic-sonarqube · 2025-06-16T16:31:03Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

elasticmachine · 2025-06-16T17:28:04Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: e94a92d

Failed CI Steps

History

💔 Build #22468 failed 576f34c
💚 Build #21978 succeeded c926ff7
💔 Build #21969 failed df2e29a
💔 Build #21968 failed cfc8a1e
💛 Build #21961 was flaky a38103f

cc @pazone

.buildkite/scripts/steps/ess.ps1

.buildkite/scripts/steps/ess.sh

github-actions · 2025-07-02T13:40:40Z

@Mergifyio backport 8.17 8.18 8.19 9.0 9.1

mergify · 2025-07-02T13:40:54Z

backport 8.17 8.18 8.19 9.0 9.1

✅ Backports have been created

#8792 [8.17] (backport #8377) [CI] BK Vault plugin for EC access has been created for branch 8.17 but encountered conflicts
#8793 [8.18] (backport #8377) [CI] BK Vault plugin for EC access has been created for branch 8.18 but encountered conflicts
#8794 [8.19] (backport #8377) [CI] BK Vault plugin for EC access has been created for branch 8.19
#8795 [9.0] (backport #8377) [CI] BK Vault plugin for EC access has been created for branch 9.0 but encountered conflicts
#8796 [9.1] (backport #8377) [CI] BK Vault plugin for EC access has been created for branch 9.1

* [CI] BK Vault plugin for ES access * Typo * Typo * Quick Windows test * Quick test Windows * Revert last two commits * Applied proposed changes * Fixed indentation * revert buildkite_analytics_token deletion * Remaned the anchor * Added the issue to comments * Updated FIPS pipeline (cherry picked from commit e2505e4) # Conflicts: # .buildkite/bk.integration-fips.pipeline.yml

* [CI] BK Vault plugin for ES access * Typo * Typo * Quick Windows test * Quick test Windows * Revert last two commits * Applied proposed changes * Fixed indentation * revert buildkite_analytics_token deletion * Remaned the anchor * Added the issue to comments * Updated FIPS pipeline (cherry picked from commit e2505e4)

* [CI] BK Vault plugin for ES access * Typo * Typo * Quick Windows test * Quick test Windows * Revert last two commits * Applied proposed changes * Fixed indentation * revert buildkite_analytics_token deletion * Remaned the anchor * Added the issue to comments * Updated FIPS pipeline (cherry picked from commit e2505e4) # Conflicts: # .buildkite/bk.integration-fips.pipeline.yml

* [CI] BK Vault plugin for ES access * Typo * Typo * Quick Windows test * Quick test Windows * Revert last two commits * Applied proposed changes * Fixed indentation * revert buildkite_analytics_token deletion * Remaned the anchor * Added the issue to comments * Updated FIPS pipeline (cherry picked from commit e2505e4)

* [CI] BK Vault plugin for ES access * Typo * Typo * Quick Windows test * Quick test Windows * Revert last two commits * Applied proposed changes * Fixed indentation * revert buildkite_analytics_token deletion * Remaned the anchor * Added the issue to comments * Updated FIPS pipeline (cherry picked from commit e2505e4) Co-authored-by: Pavel Zorin <[email protected]>

* [CI] BK Vault plugin for EC access (#8377) * [CI] BK Vault plugin for ES access * Typo * Typo * Quick Windows test * Quick test Windows * Revert last two commits * Applied proposed changes * Fixed indentation * revert buildkite_analytics_token deletion * Remaned the anchor * Added the issue to comments * Updated FIPS pipeline (cherry picked from commit e2505e4) # Conflicts: # .buildkite/bk.integration-fips.pipeline.yml * Remove backported fips pipeline --------- Co-authored-by: Pavel Zorin <[email protected]>

* [CI] BK Vault plugin for ES access * Typo * Typo * Quick Windows test * Quick test Windows * Revert last two commits * Applied proposed changes * Fixed indentation * revert buildkite_analytics_token deletion * Remaned the anchor * Added the issue to comments * Updated FIPS pipeline (cherry picked from commit e2505e4) Co-authored-by: Pavel Zorin <[email protected]>

[CI] BK Vault plugin for ES access

71d873d

pazone added the enhancement New feature or request label Jun 6, 2025

mergify bot assigned pazone Jun 6, 2025

pazone added skip-changelog backport-active-all Automated backport with mergify to all the active branches labels Jun 6, 2025

pazone added 2 commits June 6, 2025 13:17

Typo

5c40b3d

Typo

a38103f

pazone changed the title ~~[CI] BK Vault plugin for ES access~~ [CI] BK Vault plugin for EC access Jun 6, 2025

pazone mentioned this pull request Jun 6, 2025

Add Pipeline to deploy custom agent image for FIPS testing #8035

Merged

4 tasks

pazone marked this pull request as ready for review June 6, 2025 12:51

pazone requested review from a team as code owners June 6, 2025 12:51

v1v reviewed Jun 6, 2025

View reviewed changes

.buildkite/bk.integration.pipeline.yml Show resolved Hide resolved

.buildkite/scripts/steps/ess.sh Outdated Show resolved Hide resolved

pazone added 5 commits June 6, 2025 15:24

Quick Windows test

15120a0

Quick test Windows

cfc8a1e

Revert last two commits

ccf2f38

Applied proposed changes

df2e29a

Fixed indentation

c926ff7

v1v reviewed Jun 9, 2025

View reviewed changes

.buildkite/bk.integration.pipeline.yml Outdated Show resolved Hide resolved

.buildkite/bk.integration.pipeline.yml Outdated Show resolved Hide resolved

.buildkite/hooks/pre-command Outdated Show resolved Hide resolved

.buildkite/bk.integration.pipeline.yml Show resolved Hide resolved

revert buildkite_analytics_token deletion

576f34c

pazone requested a review from v1v June 16, 2025 11:26

pazone added 2 commits June 16, 2025 16:56

Remaned the anchor

e3db7ab

Added the issue to comments

924f741

v1v previously approved these changes Jun 16, 2025

View reviewed changes

pazone requested a review from pkoutsovasilis June 16, 2025 15:14

pazone added 2 commits June 16, 2025 17:16

Merge branch 'main' of github.com:elastic/elastic-agent into ci_use_v…

c874de2

…ault_plugin

Updated FIPS pipeline

e94a92d

pazone dismissed v1v’s stale review via e94a92d June 16, 2025 15:20

pazone requested a review from v1v June 16, 2025 15:21

v1v requested a review from a team June 16, 2025 15:23

v1v approved these changes Jun 16, 2025

View reviewed changes

pazone requested a review from oakrizan June 16, 2025 15:33

pkoutsovasilis reviewed Jun 19, 2025

View reviewed changes

.buildkite/scripts/steps/ess.ps1 Show resolved Hide resolved

pkoutsovasilis reviewed Jun 19, 2025

View reviewed changes

.buildkite/scripts/steps/ess.sh Show resolved Hide resolved

pazone merged commit e2505e4 into main Jul 2, 2025
19 checks passed

pazone deleted the ci_use_vault_plugin branch July 2, 2025 13:40

mergify bot mentioned this pull request Jul 2, 2025

[8.17] (backport #8377) [CI] BK Vault plugin for EC access #8792

Open

8 tasks

mergify bot mentioned this pull request Jul 2, 2025

[8.18] (backport #8377) [CI] BK Vault plugin for EC access #8793

Open

8 tasks

mergify bot mentioned this pull request Jul 2, 2025

[8.19] (backport #8377) [CI] BK Vault plugin for EC access #8794

Merged

8 tasks

This was referenced Jul 2, 2025

[9.0] (backport #8377) [CI] BK Vault plugin for EC access #8795

Merged

[9.1] (backport #8377) [CI] BK Vault plugin for EC access #8796

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CI] BK Vault plugin for EC access #8377

[CI] BK Vault plugin for EC access #8377

Uh oh!

pazone commented Jun 6, 2025 •

edited

Loading

Uh oh!

mergify bot commented Jun 6, 2025

Uh oh!

v1v left a comment

Uh oh!

Uh oh!

Uh oh!

v1v left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

v1v left a comment

Uh oh!

v1v commented Jun 16, 2025 •

edited

Loading

Uh oh!

pazone commented Jun 16, 2025

Uh oh!

elastic-sonarqube bot commented Jun 16, 2025

Uh oh!

elasticmachine commented Jun 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

mergify bot commented Jul 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

[CI] BK Vault plugin for EC access #8377

[CI] BK Vault plugin for EC access #8377

Uh oh!

Conversation

pazone commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

Uh oh!

mergify bot commented Jun 6, 2025

Uh oh!

v1v left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

v1v left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

v1v left a comment

Choose a reason for hiding this comment

Uh oh!

v1v commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pazone commented Jun 16, 2025

Uh oh!

elastic-sonarqube bot commented Jun 16, 2025

Quality Gate passed

Uh oh!

elasticmachine commented Jun 16, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

mergify bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Uh oh!

pazone commented Jun 6, 2025 •

edited

Loading

v1v commented Jun 16, 2025 •

edited

Loading

mergify bot commented Jul 2, 2025 •

edited

Loading