Fix EEP CEL Validations around FullDuplexStreamed and FailOpen #6560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: envoyproxy#6559 Signed-off-by: Arko Dasgupta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6560 +/- ##
==========================================
- Coverage 71.12% 71.11% -0.01%
==========================================
Files 220 220
Lines 37971 37971
==========================================
- Hits 27005 27004 -1
Misses 9393 9393
- Partials 1573 1574 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Arko Dasgupta <[email protected]>
zirain
approved these changes
Jul 19, 2025
jukie
approved these changes
Jul 19, 2025
Xunzhuo
reviewed
Jul 19, 2025
Member
Xunzhuo
left a comment
Xunzhuo
left a comment
There was a problem hiding this comment.
do we have any invalid testcases for this CEL?
Contributor
Author
|
yeah @Xunzhuo, its in |
zirain
pushed a commit
to zirain/gateway
that referenced
this pull request
Aug 11, 2025
…proxy#6560) * Fix EEP CEL Validations around FullDuplexStreamed and FailOpen Fixes: envoyproxy#6559 Signed-off-by: Arko Dasgupta <[email protected]>
zirain
pushed a commit
to zirain/gateway
that referenced
this pull request
Aug 11, 2025
…proxy#6560) * Fix EEP CEL Validations around FullDuplexStreamed and FailOpen Fixes: envoyproxy#6559 Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]>
arkodg
added a commit
that referenced
this pull request
Aug 11, 2025
* fix: don't block deployment creating when missing secret in EnvoyProxy (#6692) * fix: don't block deployment creating when missing secret in EnvoyProxy Signed-off-by: zirain <[email protected]> * sort httpFilters on name if priority order is same (#6600) * sort httpFilters on name if priority order is same ensures stability across translations, mitigating listener drains https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/listeners/listener_filters#filter-chain-only-update Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * fix: add missing HTTP filters for HTTP3 listener (#6584) * fix: add missing HTTP filters for HTTP3 listener Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: use per-route configuration for session persistence to avoid listener drain (#6580) use per-route configuration for session persistence to avoid listener darin Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * Fix EEP CEL Validations around FullDuplexStreamed and FailOpen (#6560) * Fix EEP CEL Validations around FullDuplexStreamed and FailOpen Fixes: #6559 Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]>
shawnh2
pushed a commit
to shawnh2/gateway
that referenced
this pull request
Sep 15, 2025
* fix: don't block deployment creating when missing secret in EnvoyProxy (envoyproxy#6692) * fix: don't block deployment creating when missing secret in EnvoyProxy Signed-off-by: zirain <[email protected]> * sort httpFilters on name if priority order is same (envoyproxy#6600) * sort httpFilters on name if priority order is same ensures stability across translations, mitigating listener drains https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/listeners/listener_filters#filter-chain-only-update Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * fix: add missing HTTP filters for HTTP3 listener (envoyproxy#6584) * fix: add missing HTTP filters for HTTP3 listener Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: use per-route configuration for session persistence to avoid listener drain (envoyproxy#6580) use per-route configuration for session persistence to avoid listener darin Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * Fix EEP CEL Validations around FullDuplexStreamed and FailOpen (envoyproxy#6560) * Fix EEP CEL Validations around FullDuplexStreamed and FailOpen Fixes: envoyproxy#6559 Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: shawnh2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6559