Skip to content

Conversation

@zhaohuabing
Copy link
Member

fixes: #6579
release-note: yes

@zhaohuabing zhaohuabing requested a review from a team as a code owner July 23, 2025 02:38
@zhaohuabing zhaohuabing added this to the v1.5.0-rc.1 Release milestone Jul 23, 2025
@zhaohuabing zhaohuabing marked this pull request as draft July 23, 2025 02:39
@zhaohuabing zhaohuabing force-pushed the fix-6579 branch 2 times, most recently from 4bd3e2c to 8268896 Compare July 23, 2025 02:43
@zhaohuabing zhaohuabing marked this pull request as ready for review July 23, 2025 02:44
@zhaohuabing zhaohuabing requested a review from arkodg July 23, 2025 02:49
@zhaohuabing zhaohuabing changed the title fix: use per-route configuration for session persistence to avoid listener… fix: use per-route configuration for session persistence to avoid listener drain Jul 23, 2025
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

❌ Patch coverage is 69.79167% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.92%. Comparing base (af990e7) to head (166a755).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/session_persistence.go 69.79% 20 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6580      +/-   ##
==========================================
+ Coverage   70.86%   70.92%   +0.06%     
==========================================
  Files         224      225       +1     
  Lines       38769    38970     +201     
==========================================
+ Hits        27472    27640     +168     
- Misses       9708     9721      +13     
- Partials     1589     1609      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhaohuabing zhaohuabing marked this pull request as draft July 23, 2025 13:44
@zhaohuabing zhaohuabing marked this pull request as ready for review July 24, 2025 05:08
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team July 25, 2025 18:50
@arkodg arkodg merged commit f5cdc1e into envoyproxy:main Jul 26, 2025
28 checks passed
zirain pushed a commit to zirain/gateway that referenced this pull request Aug 11, 2025
…tener drain (envoyproxy#6580)

use per-route configuration for session persistence to avoid listener darin

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
zirain pushed a commit to zirain/gateway that referenced this pull request Aug 11, 2025
…tener drain (envoyproxy#6580)

use per-route configuration for session persistence to avoid listener darin

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: zirain <[email protected]>
arkodg added a commit that referenced this pull request Aug 11, 2025
* fix: don't block deployment creating when missing secret in EnvoyProxy (#6692)

* fix: don't block deployment creating when missing secret in EnvoyProxy

Signed-off-by: zirain <[email protected]>

* sort httpFilters on name if priority order is same (#6600)

* sort httpFilters on name if priority order is same

ensures stability across translations, mitigating listener drains
https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/listeners/listener_filters#filter-chain-only-update

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* fix: add missing HTTP filters for HTTP3 listener (#6584)

* fix: add missing HTTP filters for HTTP3 listener

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: zirain <[email protected]>

* fix: use per-route configuration for session persistence to avoid listener drain (#6580)

use per-route configuration for session persistence to avoid listener darin

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: zirain <[email protected]>

* Fix EEP CEL Validations around FullDuplexStreamed and FailOpen (#6560)

* Fix EEP CEL Validations around FullDuplexStreamed and FailOpen

Fixes: #6559

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Co-authored-by: Huabing (Robin) Zhao <[email protected]>
shawnh2 pushed a commit to shawnh2/gateway that referenced this pull request Sep 15, 2025
* fix: don't block deployment creating when missing secret in EnvoyProxy (envoyproxy#6692)

* fix: don't block deployment creating when missing secret in EnvoyProxy

Signed-off-by: zirain <[email protected]>

* sort httpFilters on name if priority order is same (envoyproxy#6600)

* sort httpFilters on name if priority order is same

ensures stability across translations, mitigating listener drains
https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/listeners/listener_filters#filter-chain-only-update

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

* fix: add missing HTTP filters for HTTP3 listener (envoyproxy#6584)

* fix: add missing HTTP filters for HTTP3 listener

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: zirain <[email protected]>

* fix: use per-route configuration for session persistence to avoid listener drain (envoyproxy#6580)

use per-route configuration for session persistence to avoid listener darin

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: zirain <[email protected]>

* Fix EEP CEL Validations around FullDuplexStreamed and FailOpen (envoyproxy#6560)

* Fix EEP CEL Validations around FullDuplexStreamed and FailOpen

Fixes: envoyproxy#6559

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Co-authored-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding HTTPRoutes causes Listener Drains

3 participants