Adding new form factor and improving PR comments

[Mirzamohammad22]

On using the package i noticed some features could be slightly improved.

Issues:

1. Not being able to run both emulationFormFactors in the same call and see pr comments of both without replication of comments.
2. Pr comments not having information about which emulationFormFactor it ran on, anyone reviewing the pr would have to see the full report for it.

This Pr is meant to add these improvements:

1. Add a new 'both' emulationFormFactor for local lighthouse to run 'mobile' and 'desktop'
2. Add the 'mode' for pr comments so reviewers have more context to work with, without having to see the full report.

[Mirzamohammad22]

Hey @adamhenson .Awsome project, just some minor contributions based on experience on my end. Would love to have your suggestions on it.

[adamhenson]

Thanks for opening this @Mirzamohammad22. I think this could be a beneficial feature. I left a few comments. I'll work on issue #33 so we can test it.

[Mirzamohammad22]

@adamhenson Would love to have these improvements in your lighthouse check action.

[adamhenson]

Thanks for making these changes @Mirzamohammad22 - I just added a couple last ones. I think we should remove lighthouseCaller because we don't need the console log inside of it. Since we added the default emulatedFormFactor = 'mobile', the console log outside of that function works as is 👍. If I'm not making sense - I could create a PR into your branch maybe.

[adamhenson]

Yep, once we get this merged, I'll publish a new version and bump the GitHub Action to consume it.

[Mirzamohammad22]

Thanks for making these changes @Mirzamohammad22 - I just added a couple last ones. I think we should remove lighthouseCaller because we don't need the console log inside of it. Since we added the default emulatedFormFactor = 'mobile', the console log outside of that function works as is 👍. If I'm not making sense - I could create a PR into your branch maybe.
I'll make the changes, no issues.

[adamhenson]

Sorry if I wasn't clear @Mirzamohammad22. My point is that we don't need to have this block repeated now. We can leave it where it was.

EDITED: My mistake, I see why we need it, because options is changed.

[Mirzamohammad22]

No issues , let me know if the If case is fine or should i revert to lighthouseCaller

[adamhenson]

@Mirzamohammad22 thanks again for your work on this. I'm merging this into another branch I created, so I can make some minor changes. I'll let you know when I've merged and published it (should be EOD).

[Mirzamohammad22]

@Mirzamohammad22 thanks again for your work on this. I'm merging this into another branch I created, so I can make some minor changes. I'll let you know when I've merged and published it (should be EOD).

Awesome.Thanks for the approval , looking forward to having this feature in GitHub actions!

[adamhenson]

@Mirzamohammad22 this has been released added to the GitHub Action in v2.0.1 🎈 - thanks again!

[adamhenson]

Note - I updated emulatedFormFactor to accept all vs both.

[Mirzamohammad22]

@Mirzamohammad22 this has been released added to the GitHub Action in v2.0.1 🎈 - thanks again!

Thank you!