Skip to content

Conversation

@adamhenson
Copy link
Collaborator

Includes changes from #32 and minor changes on top of it.

Copy link
Collaborator

@foo-lighthouse-bot foo-lighthouse-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #35 into master will decrease coverage by 0.84%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   35.47%   34.62%   -0.85%     
==========================================
  Files          18       18              
  Lines         327      335       +8     
  Branches       93       94       +1     
==========================================
  Hits          116      116              
- Misses        149      156       +7     
- Partials       62       63       +1     
Impacted Files Coverage Δ
src/lighthouseCheck.js 0.00% <ø> (ø)
src/localLighthouse.js 6.45% <0.00%> (-1.89%) ⬇️
src/postPrComment.js 3.33% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa42e1...2a708aa. Read the comment docs.

@adamhenson
Copy link
Collaborator Author

Feel free to review this @Mirzamohammad22. Just confirming things but will merge shortly.

@adamhenson adamhenson merged commit fb52047 into master Jun 25, 2020
@adamhenson adamhenson deleted the feat/enhanced-commenting branch June 25, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants