Skip to content

feat(starfox): integrate Mac fixes and tutorial shader preparation - #1

Merged
forbesfields merged 1 commit into
mainfrom
feat/starfox-mac
Nov 6, 2026
Merged

forbesfields merged 1 commit into
mainfrom
feat/starfox-mac

Conversation

@forbesfields

Copy link
Copy Markdown
Owner

What and why

Problem

Star Fox needs the pending graphics and streaming fixes for a sharper, correctly coloured Mac picture. Its empty shader-preparation list also leaves known tutorial pipelines to first use.

Fix

Integrate seedds/nxnative PRs #1304, #1305, #1308, #1310 and #1323, with credit to their original authors. Add 772 observed startup/tutorial preparation rows and the display/loader fixture stubs required on current main.

Tradeoffs

This is a personal integration branch, not a replacement for the upstream PRs. Streaming hitches remain, and no 120 fps unlock is enabled. The preparation list covers the opening route only.

Checked

Tests

Level: live-verified

  • build_ipa_from_nsp.py <dump> --platform mac-app --show-fps -> 2,856/2,856 shaders, self-contained signed Mac app; codesign --verify --deep --strict <app> -> pass.
  • M5 Pro 24 GB, macOS 27.0, Star Fox v131072: 1920x1080 scene targets; player confirmed physical DualSense steering, firing and correct full-window picture. A 1,800-frame flight sample took 30.01 s; a longer first-use sample included hitches. Final bundle loads its preparation list before the first frame.
  • make -C dm/host/tests GAME=0400E88025B1A000 run -> pass.
  • make -C dm/gfx/tests GAME=0400E88025B1A000 check_t_image_srgb check_t_readback check_t_dirty_slots check_t_nvn -> pass; sRGB 26 checks, readback 173 checks, NVN 238 checks.
  • python -m unittest dm.tools.tests.test_patches dm.tools.tests.test_settings dm.tools.tests.test_docs -> 30 pass; final docs run -> 11 pass.
  • python -m unittest discover -s dm/tools/tests -> 1,253 pass, 23 skip, 5 errors. The same five errors reproduce on unchanged main: synthetic NSP fixtures reach the local .NET 7 extractor build before their mocked prerequisite stop.
  • regress.py impact origin/main..HEAD -> 3 games affected, 1 broad, 142 unknown. No cross-game regress.py check: Star Fox is the only built game available for this task.
  • Not checked: full campaign, 4K, 120 fps, physical gyro/rumble feel, iOS, independent review or other games.

Front ends

Front-ends: new: Star Fox v131072 exposes the build-gated Resolution setting from upstream seedds#1323.

Docs

  • Findings and limits are in the Star Fox note; the imported general fixes retain their reference entries and symptom links.
  • No shader-chain tool changed.
  • No game binaries, assets or keys are included; preparation rows contain shader and pipeline metadata only.

Deploy

After merge: rebuild from the supplied dump with --platform mac-app; no game files are hosted in this fork. The locally tested app is already built. Stack: none. Do not merge upstream as a duplicate fix bundle.

Model: Codex, gpt-6.1-sol

Combine upstream PRs seedds#1304, seedds#1305, seedds#1308, seedds#1310 and seedds#1323 for a local Mac build. Credit their original authors for the display, graphics, streaming and resolution changes. Add the observed startup/tutorial prewarm list and adapt loader/display test fixtures to the current host.
@forbesfields
forbesfields merged commit f10747b into main Nov 6, 2026
@forbesfields
forbesfields deleted the feat/starfox-mac branch November 6, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants