Repository navigation
feat(starfox): integrate Mac fixes and tutorial shader preparation - #1
Merged
Merged
Conversation
Combine upstream PRs seedds#1304, seedds#1305, seedds#1308, seedds#1310 and seedds#1323 for a local Mac build. Credit their original authors for the display, graphics, streaming and resolution changes. Add the observed startup/tutorial prewarm list and adapt loader/display test fixtures to the current host.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Problem
Star Fox needs the pending graphics and streaming fixes for a sharper, correctly coloured Mac picture. Its empty shader-preparation list also leaves known tutorial pipelines to first use.
Fix
Integrate seedds/nxnative PRs #1304, #1305, #1308, #1310 and #1323, with credit to their original authors. Add 772 observed startup/tutorial preparation rows and the display/loader fixture stubs required on current main.
Tradeoffs
This is a personal integration branch, not a replacement for the upstream PRs. Streaming hitches remain, and no 120 fps unlock is enabled. The preparation list covers the opening route only.
Checked
Tests
Level: live-verified
build_ipa_from_nsp.py <dump> --platform mac-app --show-fps-> 2,856/2,856 shaders, self-contained signed Mac app;codesign --verify --deep --strict <app>-> pass.make -C dm/host/tests GAME=0400E88025B1A000 run-> pass.make -C dm/gfx/tests GAME=0400E88025B1A000 check_t_image_srgb check_t_readback check_t_dirty_slots check_t_nvn-> pass; sRGB 26 checks, readback 173 checks, NVN 238 checks.python -m unittest dm.tools.tests.test_patches dm.tools.tests.test_settings dm.tools.tests.test_docs-> 30 pass; final docs run -> 11 pass.python -m unittest discover -s dm/tools/tests-> 1,253 pass, 23 skip, 5 errors. The same five errors reproduce on unchanged main: synthetic NSP fixtures reach the local .NET 7 extractor build before their mocked prerequisite stop.regress.py impact origin/main..HEAD-> 3 games affected, 1 broad, 142 unknown. No cross-gameregress.py check: Star Fox is the only built game available for this task.Front ends
Front-ends: new: Star Fox v131072 exposes the build-gated Resolution setting from upstream seedds#1323.
Docs
Deploy
After merge: rebuild from the supplied dump with
--platform mac-app; no game files are hosted in this fork. The locally tested app is already built. Stack: none. Do not merge upstream as a duplicate fix bundle.Model: Codex, gpt-6.1-sol