Repository navigation
feat(starfox): add resolution and frame-rate test controls - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Problem
The Star Fox test app needs independent resolution and frame-rate controls without another copy of the game data. Host-only uncapping leaves the engine at its output interval.
Fix
Add Resolution (1080p / 4K) and Frame rate (60 / 120 / Unlocked) dropdowns to the existing app. Build-gated engine stubs, opt-in Metal sync and VI buffer settings supply each combination. The installer preserves shared data, shaders, icon and the isolated save.
Tradeoffs
Supports main build a7730d0f only. SDK refresh service semantics and later-level stability remain open. This stack stays on the tested Mac integration to reuse its shader libraries.
Checked
Apple M5 Pro 24 GB, macOS 27.0; Star Fox update v131072 (0400E88025B1A000).
Tests
Level:
live-verifiedmake -C dm/host GAME=0400E88025B1A000 -j8-> passed.make -C dm/host/tests GAME=0400E88025B1A000 run-> full suite passed; VI display regression: 8 checks, 0 failed (new 4K override check fails against original implementation).test_docs.py/test_patches.py-> 11 / 16 passed; installer byte compilation andgit diff --checkpassed.codesign --verify --deep --strict-> passed; shared RomFS/shader inode, size and mtime unchanged.Front ends
Optional Mac test selector only;
scripts/configure_starfox_test.pyupdates the isolated 120 Hz Test bundle in place.Docs
python3 dm/tools/docs_symptoms.py --checkpassed.Deploy
scripts/configure_starfox_test.py <existing-test.app> --patched <rewritten> --backup <new-folder>.feat/starfox-mac), then this PR.Model: Codex, gpt-6.1-sol