Refactor display application handling#15076
Merged
guerler merged 55 commits intogalaxyproject:devfrom Nov 11, 2025
Merged
Conversation
guerler
added
area/UI-UX
kind/refactoring
4 tasks
guerler
force-pushed
the
revise_display_application
branch
2 times, most recently
from
ea86c1d to
2b8882d
Compare
guerler
force-pushed
the
revise_display_application
branch
2 times, most recently
from
6c26b30 to
6b2bb49
Compare
guerler
force-pushed
the
revise_display_application
branch
from
8a724fe to
3d6c582
Compare
guerler
force-pushed
the
revise_display_application
branch
from
0dc030c to
ba7ab20
Compare
guerler
force-pushed
the
revise_display_application
branch
from
0c0c9ba to
3dd04fb
Compare
guerler
force-pushed
the
revise_display_application
branch
4 times, most recently
from
8b9272e to
a3f1ae9
Compare
guerler
force-pushed
the
revise_display_application
branch
from
a75354a to
d052f73
Compare
guerler
force-pushed
the
revise_display_application
branch
from
dbda9b7 to
4d4e22c
Compare
davelopez
reviewed
Nov 11, 2025
| <div> | ||
| <DatasetProvider :id="datasetId" v-slot="{ result: dataset }"> | ||
| <b-alert | ||
| <DatasetProvider :id="props.datasetId" v-slot="{ result: dataset }"> |
Contributor
There was a problem hiding this comment.
If you can get rid of the DatasetProvider here (I think is one of the few usages left) and use the store, then we will be one step closer to eliminate this old pattern. Also it will likely simplify the testing.
Contributor
Author
There was a problem hiding this comment.
I'll do that in a follow-up.
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Contributor
Author
|
Failing test is unrelated. |
Contributor
Author
|
Thank you so much @davelopez. This was an important cleanup step for the remaining mako removal. |
guerler
added
the
release-testing-26.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: #21133. PR was closed three years ago based on the assumption that another branch would handle removing this mako. Reopening now to continue the cleanup, since this is among the final makos still used by Galaxy. Removes
display_application/display.makoand moves thecreate_linkfunctionality to the DisplayApplications manager and a typed FastAPI endpoint, which is used by a client-side Vue component.How to test the changes?
(Select all options that apply)
fasta,bam,vcfor other compatible filesIGV localdisplay applicationLicense