Remove legacy Visualization Mako and Controllers#21133
Merged
guerler merged 71 commits intogalaxyproject:devfrom Nov 3, 2025
Merged
Remove legacy Visualization Mako and Controllers#21133guerler merged 71 commits intogalaxyproject:devfrom
guerler merged 71 commits intogalaxyproject:devfrom
Conversation
guerler
added
area/UI-UX
kind/refactoring
guerler
force-pushed
the
remove_visualization_mako
branch
2 times, most recently
from
c056cb8 to
8417c7c
Compare
guerler
force-pushed
the
remove_visualization_mako
branch
from
358fb47 to
1e26e13
Compare
guerler
force-pushed
the
remove_visualization_mako
branch
from
0aad49e to
575f997
Compare
guerler
force-pushed
the
remove_visualization_mako
branch
2 times, most recently
from
ae2a63f to
90105d4
Compare
guerler
force-pushed
the
remove_visualization_mako
branch
from
b9d1bae to
2129a53
Compare
davelopez
reviewed
Oct 31, 2025
Contributor
davelopez
left a comment
davelopez
left a comment
There was a problem hiding this comment.
Looks good from my limited knowledge of these components 👍
Some minor comments below.
nsoranzo
reviewed
Oct 31, 2025
nsoranzo
reviewed
Oct 31, 2025
nsoranzo
reviewed
Oct 31, 2025
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
…ry.py Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
…ry.py Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
…ry.py Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
guerler
force-pushed
the
remove_visualization_mako
branch
from
894ed2a to
f534435
Compare
nsoranzo
reviewed
Oct 31, 2025
nsoranzo
reviewed
Oct 31, 2025
nsoranzo
reviewed
Oct 31, 2025
nsoranzo
reviewed
Oct 31, 2025
guerler
force-pushed
the
remove_visualization_mako
branch
from
f442b4b to
fdf6013
Compare
4 tasks
Contributor
Author
|
Remaining test failures are unrelated. |
4 tasks
Updates the VisualizationWrapper component to define props using the `interface` and `defineProps` approach for improved type safety and readability.
Refactors the VisualizationDisplay component to improve code readability and maintainability.
Improves type safety and code clarity by defining interfaces for props and emits in the VisualizationFrame component. This change ensures that the component's properties and emitted events are strongly typed, reducing the risk of runtime errors and improving maintainability.
Contributor
Author
|
Thank you so much for the review and help! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #21106. Removes legacy template-based visualization framework components, including visualization Mako templates and legacy visualization controller endpoints. With the addition of IGV, the removal of Trackster became possible, which in turn made visualizations fully API-driven and rendered entirely client-side, eliminating all server-side Mako dependencies. This resolves inconsistencies and enables the addition of new features to the visualization framework.
After this PR, the remaining makos in the Galaxy app that still need to be migrated are:
build_from_current_history.makocopy_view.mako(WIP: Replace Copy Dataset Mako with Vue Component #17507)display.mako(WIP: Refactor display application handling #15076)tool_runner.mako(WIP: Remove Tool Runner mako #21235)Then we can finalize this project by moving the bootstrapping as outlined in #21153, making the Galaxy App mako-free.
How to test the changes?
(Select all options that apply)
License