Skip to content

Drop down revision for drop_job_params migration#21122

Merged
mvdbeek merged 2 commits intogalaxyproject:devfrom
mvdbeek:fix_down_revision_drop_job_params
Oct 21, 2025
Merged

Drop down revision for drop_job_params migration#21122
mvdbeek merged 2 commits intogalaxyproject:devfrom
mvdbeek:fix_down_revision_drop_job_params

Conversation

@mvdbeek
Copy link
Copy Markdown
Member

@mvdbeek mvdbeek commented Oct 21, 2025

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek requested a review from jdavcs October 21, 2025 09:45
@github-actions github-actions Bot added the area/database Galaxy's database or data access layer label Oct 21, 2025
@github-actions github-actions Bot added this to the 26.0 milestone Oct 21, 2025
@nsoranzo
Copy link
Copy Markdown
Member

I think the same PR #21075 broke the test_keep_success_mapping_error API error.

@mvdbeek
Copy link
Copy Markdown
Member Author

mvdbeek commented Oct 21, 2025

There's a bug in the test, it should be checking for cat, not cat1, I don't know though how it used to pass ?

Copy link
Copy Markdown
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, given that it's the dev branch, this should be safe. Thanks for fixing this!

@mvdbeek mvdbeek merged commit a52d6ca into galaxyproject:dev Oct 21, 2025
55 of 58 checks passed
@nsoranzo nsoranzo deleted the fix_down_revision_drop_job_params branch October 21, 2025 14:16
@github-actions
Copy link
Copy Markdown

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/database Galaxy's database or data access layer kind/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants