Skip to content

Drop down revision for drop_job_params migration #21122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvdbeek merged 2 commits into from
Oct 21, 2025
Merged

Drop down revision for drop_job_params migration #21122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39a4995
Drop down revision for drop_job_params migration
mvdbeek Oct 21, 2025
c581747
Fix test_keep_success_mapping_error assertion
mvdbeek Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/galaxy/model/migrations/alembic/versions_gxy/a5c5455b849a_drop_job_params_column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Drop Job.params column

Revision ID: a5c5455b849a
Revises: e382f8eb5e12
Revises: cd26484899fb
Create Date: 2025-10-15 16:13:14.778789

"""
Expand All @@ -16,7 +16,7 @@

# revision identifiers, used by Alembic.
revision = "a5c5455b849a"
down_revision = "e382f8eb5e12"
down_revision = "cd26484899fb"
branch_labels = None
depends_on = None

Expand Down
2 changes: 1 addition & 1 deletion lib/galaxy_test/api/test_workflows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3809,7 +3809,7 @@ def filter_jobs_by_tool(tool_id):
assert len(filter_jobs_by_tool("__KEEP_SUCCESS_DATASETS__")) == 1, jobs
# Follow proves one job was filtered out of the exit_code_from_file
# And a single one has been sent to cat1
assert len(filter_jobs_by_tool("cat1")) == 1, jobs
assert len(filter_jobs_by_tool("cat")) == 1, jobs

def test_keep_success_mapping_paused(self):
with self.dataset_populator.test_history() as history_id:
Expand Down
Loading